Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chinese bundle properties file: Bundle_zh_CN.properties #4784

Closed
pengchengluo opened this issue Jun 26, 2018 · 10 comments
Closed

Update Chinese bundle properties file: Bundle_zh_CN.properties #4784

pengchengluo opened this issue Jun 26, 2018 · 10 comments
Assignees

Comments

@pengchengluo
Copy link
Contributor

pengchengluo commented Jun 26, 2018

The English bundle properties file has about 1800 key-value pairs. However, the Chinese bundle properties file updated two years ago and only has about 500 key-value pairs. When viewing the web pages from Chinese web browser, there are only a few Chinese Characters. So, we want to translate all the key-value pairs and update some error translation, such as
dataverse.permissions.roles.description.title=Describe the role (1000 characters max) has been erroneously translate into "描述中的作用(1000个字符)" which can't been understood by Chinese. We have translated 1000 key-value pairs based on dataverse 4.9 and plan to complete it in the following few days. We hope our updated Bundle_zh_CN.properties file could be added into dataverse code repository.

Besides, we also hope to continually update the Bundle_zh_CN.properties file in future releases of dataverse.

image

@oscardssmith
Copy link
Contributor

While you are doing this, it probably makes sense to reduce duplicate bundle entries if you see them. A script I ran last summer found that ~20% are duplicates.

@djbrooke
Copy link
Contributor

Tagging @scolapasta for his thoughts as he's coordinating internationalization efforts with other groups (see the list of child issues in #209)

@scolapasta
Copy link
Contributor

@pengchengluo that's great! We'll review when it's ready.

Be aware we are planning on updating / streamlining the bundles as part of both internationalization and the Dataverse 5.0 release, i.e. the 1800 will hopefully be reduced in scope.

(Generally, we're always in favor of "bringing back the forks", so let is know how we can help with that)

@pengchengluo
Copy link
Contributor Author

@oscardssmith,I extract the keys from Bundle.properties and use Excel to find the following 14 duplicate keys:
advanced.search.datasets.persistentId.tip
advanced.search.files.persistentId.tip
authenticationProvider.name.builtin
authenticationProvider.name.github
authenticationProvider.name.google
authenticationProvider.name.null
authenticationProvider.name.orcid
authenticationProvider.name.orcid-sandbox
authenticationProvider.name.shib
citationFrame.banner.countdownMessage.seconds
ingest.csv.invalidHeader
ingest.csv.lineMismatch
ingest.csv.nullStream
ingest.csv.recordMismatch
For advanced.search.datasets.persistentId.tip and advanced.search.files.persistentId.tip, their values are different. I also extract the keys from Bundle_zh_CN.properties and find no duplicate keys.

@pengchengluo
Copy link
Contributor Author

@scolapasta that's wonderful! We also hope to continually update the Bundle_zh_CN.properties file.

Besides, could you explain the "bringing back the forks" for me since I can't understand it exactly and there seems little information about it on the Internet. Thank you~

@pdurbin
Copy link
Member

pdurbin commented Jun 27, 2018

@pengchengluo you might remember that at lunch during the Dataverse Community Meeting I showed you a spreadsheet were we keep track of forks that we know about:

screen shot 2018-06-26 at 9 38 41 pm

@pengchengluo
Copy link
Contributor Author

@pdurbin Oh, yes, I see.

@pdurbin
Copy link
Member

pdurbin commented Jul 2, 2018

@pengchengluo thanks for pull request #4798. It only contains changes to Bundle_zh_CN.properties so I'm sure it's save to merge. It's interesting to see that "Dataverse" has been translated!

dataverse=\u6570\u636e\u7a7a\u95f4

数据空间 = data space

screen shot 2018-07-02 at 9 02 05 am

@pdurbin pdurbin assigned pdurbin and unassigned pengchengluo Jul 2, 2018
@pdurbin pdurbin removed their assignment Jul 2, 2018
@kcondon kcondon self-assigned this Jul 2, 2018
@kcondon kcondon closed this as completed Jul 2, 2018
@kcondon kcondon removed the Status: QA label Jul 2, 2018
@pengchengluo
Copy link
Contributor Author

@pdurbin as far as I know, the dataverse comes from "data + universe“, so we use the '数据空间' to represent it whenever the dataverse references the dvObject. If dataverse references the software or platform, I try to remain as it is, i.e. dataverse.

@pdurbin
Copy link
Member

pdurbin commented Jul 3, 2018

@pengchengluo interesting! It drive some of the people on the team crazy when I say this, but we sometimes refer to the DvObject dataverse as "small d dataverse" which is different than Dataverse, the software/platform. 😄 Maybe we need a better name for the DvObject. @sbarbosadataverse calls it a "personal space" during her training. This reflects how it can be customized, branded, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants