-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internationalization : Move English strings from xhtml and java to bundle.properties #4634
Comments
@JayanthyChengan thanks for creating pull request #4643! I looked it over and move it to QA at https://waffle.io/IQSS/dataverse Hopefully, by looking at the "diff" it's easy enough to figure out what to test but if you feel like adding a list here, I'm sure it would be appreciated. |
I might need to discuss with dev on the best way to test since I do not know the code. OK, I think I was able to locate most strings except for Replication for, Selected (dataverse), and View More Results (due to text being different) |
Approving for QA to merge. Reviewed the UI on the dvn-build test server and confirmed all the moving pieces looked good. Confirmed via ssh that the latest and greatest As I commented in the PR #4643 there is more bundle text additions to be made.
That list has been updated with two additional finds from my final QA review. It includes text found in |
Find and move all the english strings from xhtml files related to user interface to bundle. properties. This will centralize the words and make it easier to translate into other languages going forward.
The text was updated successfully, but these errors were encountered: