Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Related Publications" field to Create Dataset page #3838

Closed
TaniaSchlatter opened this issue May 16, 2017 · 15 comments
Closed

Add "Related Publications" field to Create Dataset page #3838

TaniaSchlatter opened this issue May 16, 2017 · 15 comments
Assignees
Labels
UX & UI: Design This issue needs input on the design of the UI and from the product owner

Comments

@TaniaSchlatter
Copy link
Member

We want to capture publications related to a dataset in the first step of creating a new dataset. This request is per meeting with Mercè May 9, 2017.

See mock up attached.

create_dataset_related_publications_field

@TaniaSchlatter TaniaSchlatter added the UX & UI: Design This issue needs input on the design of the UI and from the product owner label May 16, 2017
@djbrooke djbrooke added ready and removed ready labels May 16, 2017
@landreev
Copy link
Contributor

Turned the "displayoncreate" fields to TRUE, for the 4 entries in the citation block that correspond to the "related publication" field.

To activate, the citation block needs to be re-ingested.
The following instruction on how to do this needs to be added to the release instructions:

We have made a minor update to the Citations metadata configuration: The "Related Publication" fields will now be included on the "Create New Dataset" page. (And not just on the "Edit Metadata" page for existing datasets. To keep your Citation metadata configuration up-to-date, re-ingest the metadata block file supplied with the Dataverse distribution, as follows:

curl http://localhost:8080/api/admin/datasetfield/load -X POST --data-binary @data/metadatablocks/citation.tsv -H "Content-type: text/tab-separated-values"

Also, PLEASE NOTE/REVIEW:
The Create Dataset page will NOT match the mock up, above, 1-to-1;
that's because the "related publication" is not 1 field, but 3. It will be displayed the same exact way as it's been shown on the "Edit Metadata" page, for existing/already created datasets. I'm assuming this is the desired behavior.

@landreev
Copy link
Contributor

pull request: #3841

@landreev landreev removed their assignment May 19, 2017
@pdurbin
Copy link
Member

pdurbin commented May 19, 2017

I just reviewed pull request #3841 and it looks good, exactly the small change we talked about when estimating this issue. I'll move it to QA at https://waffle.io/IQSS/dataverse

This is out of scope, but I'd like to point out that for situations like this where we're asking users to reload a tsv file containing metadata blocks, I'd love to have a "preview" mode, which is why I opened #2551 a while back.

@djbrooke
Copy link
Contributor

@TaniaSchlatter - @landreev asked if you could take a look. He'll add a screenshot here.

@landreev
Copy link
Contributor

Yes, this is just to illustrate how the actual "Add new Dataset" page looks different from the mock up. The "Related Publication" is 3 fields, rather than one; and this identical to how it's rendered on the "Edit Metadata" page, for an existing dataset:
screen shot 2017-05-19 at 11 47 43 am

@dlmurphy
Copy link
Contributor

dlmurphy commented May 22, 2017

I just looked into it, and this feature does not require any additions or changes to the guides.

The Related Publications feature that currently exists on the Edit Metadata page uses some really helpful tooltips, please be sure that these tooltips are also in place when the feature is added to the Add Dataset page.

@pdurbin
Copy link
Member

pdurbin commented May 22, 2017

@dlmurphy thanks. Also, @landreev @kcondon @mheppler @raprasad and I discussed this issue this morning and we decided to go ahead and move it to QA, which I'll do now.

@TaniaSchlatter
Copy link
Member Author

Can the URL field display the width of the Citation and and notes blocks? Or, left aligned as "Vocabulary URL" above?

@pdurbin
Copy link
Member

pdurbin commented May 23, 2017

@pameyer pointed out that #3679 is related. Good point. Thanks.

@pdurbin
Copy link
Member

pdurbin commented May 23, 2017

@TaniaSchlatter it's a good idea but we estimated this issue based on the simple change made in pull request #3841 and we should be careful not to expand the scope of this (or any) issue. Can you please open a new issue about the width and alignment so it can be estimated separately? Thanks!

@kcondon kcondon self-assigned this May 24, 2017
@kcondon kcondon closed this as completed May 24, 2017
@pdurbin pdurbin added this to the 4.6.2 - Tabular Mapping milestone May 24, 2017
@TaniaSchlatter
Copy link
Member Author

If I had caught the alignment issue before it was tagged to go to QA would you still see shifting alignment as needing a github issue, @pdurbin?

@pdurbin
Copy link
Member

pdurbin commented May 31, 2017

@TaniaSchlatter yes because when we estimated this issue we gave it a "2" or whatever (Waffle is down right now so I can't check). If we wanted to include changes to the design, we would have given it a higher number, like a 5 or an 8, depending on how many UI changes we thought we wanted. We may not have even taken it on during this sprint if the number got too high.

@TaniaSchlatter
Copy link
Member Author

@pdurbin Making a UI field field consistent is not and should not be considered a "UI change." If it is, then we have and will continue to have major UI issues.

@pdurbin
Copy link
Member

pdurbin commented May 31, 2017

@TaniaSchlatter I couldn't agree with you more!

@dlmurphy
Copy link
Contributor

Talked with Danny about this. The alignment fix would have been OK to work on in this issue, but since it has been closed I've made a new issue for it, #3871.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

6 participants