-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permissions: Removing role "Success" notification incorrectly displays in "Assign Role" dialogue #2745
Comments
@sbarbosadataverse I tried recreating this today and I couldn't get it to happen on demo.dataverse.org. can i pass this to @kcondon to try and if it isn't happening, close? i'm wondering if this was one of those things that happened when the servers were acting up. |
I suspect the blue spinner is seen only briefly as of 4.2.3 since I made the expensive part of changing roles asynchronous as part of #2036. I'd suggest we re-test this issue. I guess I'll assign it to @sbarbosadataverse but @kcondon or @scolapasta or @eaquigley or @mheppler can let me know if the process should be different. Not sure if I should set a milestone or not. |
No need for a milestone. Save that label for development on features and bug fixes that are going to be merged into "develop". With this issue, we're still in the triage phase of trying to determine if this is still a bug and if it can be closed or needs to be fixed still. I have tested this locally on a post-4.2.3 branch off develop and couldn't reproduce after a few tries. I believe our permissions-related performance improvements have resolved this. Unless this is a success/validation issue with the popup messages getting signals crossed page messages, which can still be fixed. |
since this happened in production, no need to assign it to me to test. If it happens again, I will create a new ticket. |
When removing a role, the blue spinner and success message shows up on the screen. You then navigate to the "Assign role" dailogue box, and while in the midst of adding a new role for a user, you see another "success" message show up in the "assign role" dialogue box, repeating the first success message of "user role removed" and this of course interrupts the process of adding the new user.
won't attach screen shot for security purposes. I have a copy on my desktop
The text was updated successfully, but these errors were encountered: