Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions: Removing role "Success" notification incorrectly displays in "Assign Role" dialogue #2745

Closed
sbarbosadataverse opened this issue Nov 17, 2015 · 5 comments
Assignees
Labels
Feature: Permissions Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner

Comments

@sbarbosadataverse
Copy link

When removing a role, the blue spinner and success message shows up on the screen. You then navigate to the "Assign role" dailogue box, and while in the midst of adding a new role for a user, you see another "success" message show up in the "assign role" dialogue box, repeating the first success message of "user role removed" and this of course interrupts the process of adding the new user.

won't attach screen shot for security purposes. I have a copy on my desktop

@sbarbosadataverse sbarbosadataverse added the Type: Bug a defect label Nov 17, 2015
@mercecrosas mercecrosas modified the milestone: In Review Nov 30, 2015
@eaquigley
Copy link
Contributor

@sbarbosadataverse I tried recreating this today and I couldn't get it to happen on demo.dataverse.org. can i pass this to @kcondon to try and if it isn't happening, close? i'm wondering if this was one of those things that happened when the servers were acting up.

@sbarbosadataverse
Copy link
Author

Depends when the server was acting up. This wasn't that far back. I've
noticed lingering dialogue boxes as recent as this week.

On Wed, Dec 16, 2015 at 10:32 AM, Elizabeth Quigley <
[email protected]> wrote:

@sbarbosadataverse
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_sbarbosadataverse&d=CwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=8R6PzVqt1PEocauQgZMGXsGz29-nb19M7eqlo1d8EVs&m=wP7w3PhCpX3pNbO2ZAtDJ84BiS4FEjOM8dj8DnYp3BU&s=zY_UYndVI4LLBP-8c_6aQibOssNhRkg3ROLBfWVARts&e=
I tried recreating this today and I couldn't get it to happen on
demo.dataverse.org. can i pass this to @kcondon
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_kcondon&d=CwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=8R6PzVqt1PEocauQgZMGXsGz29-nb19M7eqlo1d8EVs&m=wP7w3PhCpX3pNbO2ZAtDJ84BiS4FEjOM8dj8DnYp3BU&s=ElVFvPe5eCMIVGxktXqBpgqjuWZqdP_gcwSeiGngj7s&e=
to try and if it isn't happening, close? i'm wondering if this was one of
those things that happened when the servers were acting up.


Reply to this email directly or view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_IQSS_dataverse_issues_2745-23issuecomment-2D165144344&d=CwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=8R6PzVqt1PEocauQgZMGXsGz29-nb19M7eqlo1d8EVs&m=wP7w3PhCpX3pNbO2ZAtDJ84BiS4FEjOM8dj8DnYp3BU&s=ZVJdEHdb1X7M4IHhSDJssZ_cShX_ucH1KxFrGjf83xY&e=
.

Sonia Barbosa
Manager of Data Curation, IQSS Dataverse Network
Manager of the Murray Research Archive, IQSS
Data Science
Harvard University

Dataverse 4.0 is now available for use!
http://dataverse.harvard.edu

All test dataverses should be created in 4.0 Demo!
http://dataverse-demo.iq.harvard.edu/

Join our Dataverse Community!
https://groups.google.com/forum/#!forum/dataverse-community

@mheppler mheppler changed the title Permissions: "success" notification for removing a role is showing up in "Assign role" dialogue box Permissions: Removing role "Success" notification incorrectly displays in "Assign Role" dialogue Dec 16, 2015
@scolapasta scolapasta removed their assignment Jan 27, 2016
@mheppler mheppler added UX & UI: Design This issue needs input on the design of the UI and from the product owner Feature: Permissions labels Jan 28, 2016
@scolapasta scolapasta modified the milestone: Not Assigned to a Release Jan 28, 2016
@pdurbin
Copy link
Member

pdurbin commented Feb 10, 2016

I suspect the blue spinner is seen only briefly as of 4.2.3 since I made the expensive part of changing roles asynchronous as part of #2036.

I'd suggest we re-test this issue. I guess I'll assign it to @sbarbosadataverse but @kcondon or @scolapasta or @eaquigley or @mheppler can let me know if the process should be different. Not sure if I should set a milestone or not.

@mheppler
Copy link
Contributor

No need for a milestone. Save that label for development on features and bug fixes that are going to be merged into "develop". With this issue, we're still in the triage phase of trying to determine if this is still a bug and if it can be closed or needs to be fixed still.

I have tested this locally on a post-4.2.3 branch off develop and couldn't reproduce after a few tries. I believe our permissions-related performance improvements have resolved this. Unless this is a success/validation issue with the popup messages getting signals crossed page messages, which can still be fixed.

@sbarbosadataverse
Copy link
Author

since this happened in production, no need to assign it to me to test. If it happens again, I will create a new ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Permissions Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

6 participants