Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DvObjects to be persisted even if there are Solr errors (more try/catch) #1749

Closed
pdurbin opened this issue Mar 23, 2015 · 4 comments
Closed
Labels

Comments

@pdurbin
Copy link
Member

pdurbin commented Mar 23, 2015

#229 ("Create Dataset: Allow data set to be created even if not able to index. Manage index failures for later correction) handled the case of Solr being down but if the Solr schema is out of date DvObjects still can't be persisted. You'll get an error like this:

org.apache.solr.client.solrj.impl.HttpSolrServer$RemoteSolrException: ERROR: [doc=dataset_10_draft] unknown field 'whateverTheNewFieldIs'

In a lot of methods we catch SolrServerException and IOException. I think if we add HttpSolrServer.RemoteSolrException to the list of exceptions we catch, we'll be able to persist objects to the database even if the Solr schema is out of date.

Of course this raises the question of keeping Solr in sync with the database. In #702 I started working on a "status" page/endpoint to know when Solr is out of date (missing documents and orphaned documents). That ticket still needs more work in that regard. Right know it's hard to know the status of Solr being in sync with the database.

The question for this ticket is if we should go ahead and let DvObjects be created if the Solr schema is out of date. @scolapasta we had talked about this with @ekraffmiller in the context of "more try/catch". I'll give this to you for now to think about.

@bencomp
Copy link
Contributor

bencomp commented Apr 16, 2015

We just ran into the issue of the Solr schema being out of date. If there such a strong interdependence between the Dataverse version and Solr schema, I would suggest to make sure they are updated in a single "transaction". The documentation has to say

The Solr schema MUST be updated at the same time as the Dataverse application WAR.

@pdurbin
Copy link
Member Author

pdurbin commented Apr 16, 2015

@bencomp this is an excellent point. We could really use some help improving the Installation Guide in #913 if you or anyone is interested!

@pdurbin
Copy link
Member Author

pdurbin commented Aug 14, 2015

#2321 is the new issue for improving documentation.

@scolapasta scolapasta removed their assignment Jan 27, 2016
@scolapasta scolapasta removed this from the Not Assigned to a Release milestone Jan 28, 2016
@pdurbin pdurbin added Component: Code Infrastructure formerly "Feature: Code Infrastructure" and removed zTriaged labels Jun 27, 2017
@pdurbin
Copy link
Member Author

pdurbin commented Jun 28, 2017

I guess we're surviving with the way things are. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants