Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Submit for Review" Option for Datasets Uploaded by CAFE Admin #10577

Closed
Saixel opened this issue May 21, 2024 · 2 comments
Closed

Add "Submit for Review" Option for Datasets Uploaded by CAFE Admin #10577

Saixel opened this issue May 21, 2024 · 2 comments
Assignees
Labels
NIH CAFE Issues related to and/or funded by the NIH CAFE project Size: 80 A percentage of a sprint. 56 hours. Type: Feature a feature request

Comments

@Saixel
Copy link
Contributor

Saixel commented May 21, 2024

Background

Currently, when a public user (i.e., no administrator privileges) submits a dataset to the CAFE repository, they can either "save as draft" or "submit for review." However, when a CAFE administrator uploads a dataset to the repository, the options are "save as draft" or "publish."

Issue

We need to add a third option, "submit for review," for datasets uploaded by CAFE administrators. This will allow other administrators to review the dataset and metadata before it is published.

Feature Request

  • Implement a "submit for review" option for datasets uploaded by CAFE administrators.
  • Ensure that this option allows datasets to be reviewed by other administrators before publication.

Justification

This feature will ensure that datasets uploaded by administrators undergo the same review process as those uploaded by public users, maintaining data quality and consistency.

Implementation Considerations

  • Review the current workflow for dataset submission by administrators.
  • Develop and test the necessary changes to include the "submit for review" option.
  • Ensure that the review process for administrators is consistent with the process for public users.

Additional Context

This request emerged from discussions during the data management meeting, highlighting the need for a review process for datasets uploaded by administrators to ensure metadata standards are met before publication.

@Saixel Saixel added Type: Feature a feature request NIH CAFE Issues related to and/or funded by the NIH CAFE project labels May 21, 2024
@Saixel Saixel self-assigned this May 21, 2024
@Saixel Saixel added the Size: 80 A percentage of a sprint. 56 hours. label Jul 17, 2024
@sbarbosadataverse
Copy link

sbarbosadataverse commented Oct 8, 2024

@Saixel Hi Alexis,
It would be best if CAFE turned all non essential admins into "contributors," and they can all submit their content for review.
The existing workflow allows all collection admins to publish content, a concrete action. Changing this workflow would break the collection-level admin permission workflow. Does everyone listed as an admin now in CAFE need to have that role? If not, they can be moved to contributors. We would not implement this type of hybrid contributor/admin role in HDV production because I can foresee the problems it would cause for collections.

@Saixel
Copy link
Contributor Author

Saixel commented Nov 21, 2024

Following the recommendation, we decided to convert non-essential admins to "contributors." This solution allows contributors to submit content for review without disrupting the current collection-level admin permission workflow. As this approach meets the intended objective, we are marking this as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NIH CAFE Issues related to and/or funded by the NIH CAFE project Size: 80 A percentage of a sprint. 56 hours. Type: Feature a feature request
Projects
Status: Done 🧹
Development

No branches or pull requests

2 participants