Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geospatial metadata block > bounding box coordinates fields > tool tips are INCORRECT and mention use of commas #10397

Closed
amberleahey opened this issue Mar 20, 2024 · 6 comments · Fixed by #10447
Labels
Feature: Geospatial NIH CAFE Issues related to and/or funded by the NIH CAFE project Size: 3 A percentage of a sprint. 2.1 hours. Type: Bug a defect
Milestone

Comments

@amberleahey
Copy link

Using 6.1 release
-->
What steps does it take to reproduce the issue?
enter geospatial metadata > bounding box coordinates for a dataset using the tool tips in Dataverse UI (hover over coordinate field boxes)
image1

This tool tip in the UI mentions the use of commas instead of decimals points, this is incorrect formatting and will fail against the validation now added for geospatial bounding box validation for geospatial search

  • When does this issue occur?
    Enter this metadata according to the UI tool tip and it will fail
    image2
    image4
    image3

  • Which page(s) does it occurs on?

Geospatial metadata > bounding box coordinates

  • What happens?
    fails when using tool tip in UI for use of commas in coordinates (not best practice and will fail validation)

  • To whom does it occur (all users, curators, superusers)?
    all users

  • What did you expect to happen?

Let's improve the tool tip to remove mention of commas and replace with decimals. The general UI tool tip for this field can specify only - and decimals . are appropriate to use

Which version of Dataverse are you using?
6.1

Any related open or closed issues to this bug report?
yes lots for geospatial metadata, will link shortly

Screenshots:

No matter the issue, screenshots are always welcome.

To add a screenshot, please use one of the following formats and/or methods described here:

@amberleahey
Copy link
Author

Related to: #7455 ; #7947 ; #7108 ; #7091 ; #10397

@amberleahey
Copy link
Author

Dataverse Guides need to be changed as well : https://docs.google.com/spreadsheets/d/13HP-jI_cwLDHBetn9UKTREPJ_F4iHdAvhjmlvmYdSSw/edit#gid=4 & https://github.com/IQSS/dataverse/blob/master/scripts/api/data/metadatablocks/geospatial.tsv

We will be updating this in our user guides and best practices as well.

@cmbz cmbz added the NIH CAFE Issues related to and/or funded by the NIH CAFE project label Mar 20, 2024
@sbarbosadataverse sbarbosadataverse added the Size: 3 A percentage of a sprint. 2.1 hours. label Mar 20, 2024
@sbarbosadataverse
Copy link

sbarbosadataverse commented Mar 20, 2024

3/20/24 GitHub issue review meeting with Gustavo, Sonia, Julian:

Gustavo is sizing this as a "3" to address the tooltip changes mentioned "Let's improve the tool tip to remove mention of commas and replace with decimals. The general UI tool tip for this field can specify only - and decimals . are appropriate to use"

Once the tooltip is changed in the metadata block's TSV file (https://github.com/IQSS/dataverse/blob/master/scripts/api/data/metadatablocks/geospatial.tsv), and in the .properties file, @jggautier will make this change in the copy that's in Google Sheets (https://docs.google.com/spreadsheets/d/13HP-jI_cwLDHBetn9UKTREPJ_F4iHdAvhjmlvmYdSSw/edit#gid=4)

@amberleahey, we're thinking that the larger discussion about the use of commas will happen later. Is that right? It seems like an internationalization issue.

@sbarbosadataverse sbarbosadataverse moved this to SPRINT READY in IQSS Dataverse Project Mar 20, 2024
@Saixel Saixel assigned Saixel and unassigned Saixel Mar 25, 2024
@landreev landreev moved this from SPRINT READY to This Sprint 🏃‍♀️ 🏃 in IQSS Dataverse Project Mar 27, 2024
@jp-tosca jp-tosca self-assigned this Mar 28, 2024
@jp-tosca jp-tosca moved this from This Sprint 🏃‍♀️ 🏃 to In Progress 💻 in IQSS Dataverse Project Mar 28, 2024
@landreev
Copy link
Contributor

landreev commented Mar 28, 2024

Really weird that we managed to miss this, when we invested a good effort into fixing the actual validation for the values (I consulted on and reviewed the fixes, so I'm taking responsibility for it). We are going to try and add the fixed tooltips to 6.2 tomorrow (updating the block is already part of the 6.2 upgrade, so why not address this as well).

To address some questions from the planning meeting yesterday - yes, there are some places in the world where commas are used in coordinate values. I don't think we should worry about this in the context of fixing the tooltips in the block as we distribute it. Our normal approach is for all the labels in the core blocks to be in en_US locale. They can be localized through extra properties files if desired. It's slightly less complicated for these specific tooltips - they are not just labels, they need to match the validation rules that will be applied to the entered values. So, anyone translating this particular block would need to check and confirm how the validation works in their locale. But, once again, I don't think this should be a concern for the purposes of fixing the block .tsv as distributed.

@amberleahey
Copy link
Author

amberleahey commented Mar 28, 2024

amazing thanks! agree, we noted some use of commas in metadata in French in Quebec here in Canada, but largely this is for display and many technical GIS systems use decimals widely. Thanks again for these fixes in 6.2 looking forward to using the new validation in the block! Maybe one day we can handle different encoding in the metadata like what is done for data files in tabular ingest (for encoding ), for the future!

@landreev
Copy link
Contributor

(Just read my comment from the other day - I obviously meant "... it's slightly more complicated", not "less" 🙂)

@jp-tosca jp-tosca removed their assignment Mar 29, 2024
@pdurbin pdurbin added this to the 6.2 milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Geospatial NIH CAFE Issues related to and/or funded by the NIH CAFE project Size: 3 A percentage of a sprint. 2.1 hours. Type: Bug a defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants