Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format total in table pagination results according to browser language. #330

Closed
g-saracca opened this issue Mar 4, 2024 · 0 comments · Fixed by #383
Closed

Format total in table pagination results according to browser language. #330

g-saracca opened this issue Mar 4, 2024 · 0 comments · Fixed by #383
Labels
good first issue Good for newcomers pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 10 A percentage of a sprint. 7 hours.

Comments

@g-saracca
Copy link
Contributor

g-saracca commented Mar 4, 2024 •
edited
Loading

The objective is to format the total number of items of the pagination result according to the preferred language in the user's browser.

total_files

For example:

  • 1 to 10 of 10,000 Files (with 'en' locale)
  • 1 to 10 of 10.000 Files (with 'es' locale)

We could use Intl.NumberFormat native browser api, passing undefined as language.
It has a %97.16 browser support so it is more than safe to use according to caniuse
@g-saracca g-saracca added good first issue Good for newcomers Size: 10 A percentage of a sprint. 7 hours. pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows labels Mar 4, 2024
@g-saracca g-saracca assigned g-saracca and unassigned g-saracca Mar 4, 2024
@b-hok b-hok mentioned this issue Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 10 A percentage of a sprint. 7 hours.
Projects
IQSS Dataverse Project
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Add pagination total results b-hok/dataverse-frontend
1 participant
@g-saracca