Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class ZCL_MQTT_PACKET_CONNECT constructor issue #14

Open
nomssi opened this issue Oct 24, 2019 · 2 comments
Open

Class ZCL_MQTT_PACKET_CONNECT constructor issue #14

nomssi opened this issue Oct 24, 2019 · 2 comments

Comments

@nomssi
Copy link
Contributor

nomssi commented Oct 24, 2019

In constructor
mv_password = iv_password.
fails because of the implicit convertion String -> XString

@larshp
Copy link
Contributor

larshp commented Oct 24, 2019

thanks, pull requests welcome

@nomssi
Copy link
Contributor Author

nomssi commented Oct 24, 2019

will create one (eventually) but first the fix:

  1. in ZCL_MQTT_PACKET_CONNECT constructor:
    mv_password = cl_binary_convert=>string_to_xstring_utf8( CONV #( iv_password ) ).
  2. in ZIF_MQTT_PACKET~ENCODE( )
    IF NOT mv_password IS INITIAL.
    lv_length = xstrlen( mv_password ). " <-- fix, was xstrlen( ms_will_message-message ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants