Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lib microservice #23

Closed
prasadtalasila opened this issue Mar 29, 2023 · 4 comments
Closed

Fix lib microservice #23

prasadtalasila opened this issue Mar 29, 2023 · 4 comments

Comments

@prasadtalasila
Copy link
Contributor

prasadtalasila commented Mar 29, 2023

The following changes are required to make the lib microservice work better:

  1. There are warnings during yarn install, is it due to using not the latest packages?
  2. lib microservice must generate schema.gql from codebase.
@prasadtalasila prasadtalasila changed the title extract graphql schema from lib microservice Fix lib microservice Mar 29, 2023
@prasadtalasila
Copy link
Contributor Author

Adds docs/LIB-MS.md

@ravvnen
Copy link
Contributor

ravvnen commented Mar 30, 2023

After this, fix CodeClimate Issues

@ravvnen
Copy link
Contributor

ravvnen commented Mar 30, 2023

  1. I have fixed the yarn install warnings, i removed @nestjs/axios, and updated rxjs aswell as express
  2. the schema does generate the schema.gql from the codebase already, using the graphqlmodule
  3. I have a LIB-MS.md, but i would like to quickly draft it with you tomorrow

this is all in my dev branch -

ref to the lib-ms.md .. https://github.com/ravvnen/DTaaS/blob/dev/docs/LIB-MS.md
ref to the graphql module .. line 13 - https://github.com/ravvnen/DTaaS/blob/dev/servers/lib/src/app.module.ts

@prasadtalasila
Copy link
Contributor Author

Completed in PR #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants