Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release Spoon 10.4.0 #5257

Closed
monperrus opened this issue Jun 8, 2023 · 14 comments · Fixed by #5258
Closed

release Spoon 10.4.0 #5257

monperrus opened this issue Jun 8, 2023 · 14 comments · Fixed by #5258

Comments

@monperrus
Copy link
Collaborator

FYI, we're trying the new release pipeline now, see #3890

@MartinWitt
Copy link
Collaborator

MartinWitt commented Jun 8, 2023

Okay learnings from the failing release:

Also, we run in the first time release problem with the script and the SemVer plugin. For major and minor releases.
see #5209 (comment).

semver next patch 10.2.1-SNAPSHOT
10.2.1
semver next major 10.2.1-SNAPSHOT
10.2.1
If it is a snapshot, the plugin simple strips the snapshot and calls it day.

A workaround is doing a patch release, and we should get 10.4.0.

@MartinWitt
Copy link
Collaborator

Okay I tried it a second time and the GPG plugin fails see https://github.com/INRIA/spoon/actions/runs/5224090878/jobs/9431846062#step:13:2653.

@MartinWitt
Copy link
Collaborator

Okay next fix should be #5263. I'm not certain why we have this plugin, maybe for the beta releases? JReleaser handles the signing by itself, but lets see.

@MartinWitt
Copy link
Collaborator

Okay the next problem with the GPG plugin is that we have to pass the name of the envvar for the password and not the password itself, see https://stackoverflow.com/questions/74909075/unable-to-decrypt-gpg-passphrase-with-org-apache-maven-pluginsmaven-gpg-plugin.

gpgPassphrase should be the name of the env var that is going to contain the GPG passphrase and in the release/deploy stages you need to include that formerly mentioned env var in the env section, and set its value (in your case the secrets.MAVEN_GPG_PASSPHRASE).

@monperrus
Copy link
Collaborator Author

monperrus commented Jun 13, 2023

FTR, last run is https://github.com/INRIA/spoon/actions/runs/5242929888

next step is #5267

@monperrus
Copy link
Collaborator Author

@MartinWitt
Copy link
Collaborator

As an update the FF-merge works for maven-lockfile now. Time to part all knowledge to our spoon script. https://github.com/chains-project/maven-lockfile/blob/main/.github/workflows/jreleaser.yml

@MartinWitt
Copy link
Collaborator

#5279 this is the next step in the CD release fixing.

@MartinWitt
Copy link
Collaborator

Related #5272.

@MartinWitt
Copy link
Collaborator

MartinWitt commented Jun 15, 2023

Error: Failed to execute goal org.sonatype.plugins:nexus-staging-maven-plugin:1.6.13:deploy (injected-nexus-deploy) on project spoon-core: Execution injected-nexus-deploy of goal org.sonatype.plugins:nexus-staging-maven-plugin:1.6.13:deploy failed: Server credentials with ID "ossrh" not found! -> [Help 1]

Okay progress, we somehow have a second deploy plugin in the spoon parent pom see error message. We can just skip this or remove this plugin even. The parent pom was never deployed in the last years so removing is possible but could break something.

@MartinWitt
Copy link
Collaborator

Okay next stopper is central requires for us to also publish the parent. I will provide a PR for this.

@MartinWitt
Copy link
Collaborator

MartinWitt commented Jul 6, 2023

Okay partial success. Spoon 10.4.0, the parent and javadoc is now on maven-central. We also have tag and a commit on the master. But the master is currently red. The changelog generation searched for a tag in the same format and didn't found any. As a result there was a changelog from the start of spoon. This changelog was too large for the release.

I finished the release process manually (creating a GitHub release, update to 10.4.1-SNAPSHOT and FF-merge master). Sadly we had to use the github generated changelog now and the formatted one from JReleaser.

@monperrus
Copy link
Collaborator Author

good progress on this important item, thanks @MartinWitt

@monperrus
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants