Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move from Log4j API to SLF4J API #3686

Closed
monperrus opened this issue Nov 10, 2020 · 3 comments · Fixed by #3755
Closed

refactor: move from Log4j API to SLF4J API #3686

monperrus opened this issue Nov 10, 2020 · 3 comments · Fixed by #3755
Labels
good first issue refactor

Comments

@monperrus
Copy link
Collaborator

For sake of future maintenance, we need to depend on the SLF4J API (instead of the Log4J API)

See discussion in #3678
@MartinWitt
Copy link
Collaborator

MartinWitt commented Nov 10, 2020 •
edited
Loading

As a small note: We can skip an anti corruption layer or any other abstraction and directly use sl4j. See http://slf4j.org/faq.html#optional_dependency for arguments.

@monperrus
Copy link
Collaborator Author

We could write a spoon transformation for this, to be applied on Spoon itself, and we would use the sniper mode to have a minimal diff.

@andrewbwogi
Copy link
Contributor

I have a fix for this.

@andrewbwogi andrewbwogi mentioned this issue Jan 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use slf4j API instead of log4j-api andrewbwogi/spoon
3 participants
@monperrus @MartinWitt @andrewbwogi