Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink sssom strict mode as default for lexmatch #587

Closed
cmungall opened this issue Jun 1, 2023 · 6 comments · Fixed by #601
Closed

Rethink sssom strict mode as default for lexmatch #587

cmungall opened this issue Jun 1, 2023 · 6 comments · Fixed by #601
Assignees

Comments

@cmungall
Copy link
Collaborator

cmungall commented Jun 1, 2023

I frequently run lexmatch on a new set, wait, then see a message

ValueError: [''] are used in the SSSOM mapping set but it does not exist in the prefix map

I then remember to set --no-ensure-strict-prefixes

Either:

  • --no-ensure-strict-prefixes should be default
  • an automatic repair with warnings should be default
  • an initial scan should be performed and failure should happen before my CPU has wasted a lot of cycles doing an alignment
@matentzn
Copy link
Contributor

matentzn commented Jun 1, 2023

Can we generate a random prefix and curify in this case, adding logger warning?

@cmungall
Copy link
Collaborator Author

cmungall commented Jun 1, 2023

you mean a random prefix expansion? I think having some kind of example.org/unknown/ type default expansion + warning would be ok. This would be trivial to fix in the header during post-processing / editing

@hrshdhgd
Copy link
Collaborator

hrshdhgd commented Jun 1, 2023

I remember fixing the code such that "" is not flagged as a missing prefix. Which version of sssom-py is this?

@hrshdhgd
Copy link
Collaborator

hrshdhgd commented Jun 1, 2023

I fixed it 4 months ago

@cmungall
Copy link
Collaborator Author

cmungall commented Jun 1, 2023

sssom-schema = ">=0.11.0"
sssom = ">=0.3.26"

@hrshdhgd
Copy link
Collaborator

hrshdhgd commented Jun 1, 2023

Yeah then this should not be happening. Can you show me an example for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants