-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kosovo label on the map #1036
Comments
@tovari Should Kosovo appear only on the map embedded in GO or should it be available on all places where the default GO Mapbox Style is used? I'm asking this because, by default, in the GO Mapbox style, we ignore any non-independent territory for admin-0 label. Kosovo is filtered out because it's independent=false If we need this across all maps, we should change in Mapbox Studio. |
@tovari @davidmuchatiza another question — is this only the case for Kosovo or should all non-independent admin0 labels show up on the map? |
@geohacker, Kosovo should appear on all maps, so it could be added to the Mapbox Style. |
Ok! I've added Kosovo with a slightly different style on Mapbox Studio style as well as opened a PR for the go-frontend maps IFRCGo/go-frontend#2863 We should probably work on getting the map styles matched up across the board but that's another ticket. |
Still open as PR IFRCGo/go-frontend#2863 is not approved.
|
@tovari Just making sure about the behavior here
Quick question, are there other similar dependent region that we should show in the map? I think we should add an option to force view the label for dependent country in the admin panel instead of using hard coded Also regarding,
Yes it should be possible to changes disclaimer for a specific country page. It should also be possible to show different disclaimer based on the zoom level and current view as well. |
Yeah we might want to add a |
correct @frozenhelium. |
Also, if I search for Kosovo, I'm shown a list of (old) emergencies where the country = Kosovo. If I try to open any of them, I'm shown this error: |
We looked into this. Kosovo is responding with a null value for the bounding box. A quick fix would be to add the bounding box using the GO admin panel for Kosovo. |
@udaynwa I've set a boundary box for Kosovo (via db). |
This issue does not show up now after fixing the bbox in Kosovo. |
The Kosovo label is still not visible on the map. |
Both Serbia and Kosovo are selected when hovered on the map, till a certain zoom level. |
@davidmuchatiza I think, this needs to be fixed from mapbox studio |
We need to display 'Kosovo' on the map and also add a specific disclaimer.
The typography should be somewhat lighter than the normal country names (e.g. font light version, or grey)
The map disclaimer text:
The name and boundaries of Kosovo are consistent with UN Security Council Resolution 1244 and the ICJ's Advisory Opinion on the Unilateral Declaration of Independence in Respect of Kosovo.
@frozenhelium, What are the display options for disclaimers? Can we show based on map view, zoom scale? Can we specify text in the disclaimer box based on the page url (e.g. showing it only on the map on the Serbia page)?
The text was updated successfully, but these errors were encountered: