Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kosovo label on the map #1036

Open
tovari opened this issue Jul 3, 2023 · 17 comments · May be fixed by IFRCGo/go-frontend#2863
Open

Kosovo label on the map #1036

tovari opened this issue Jul 3, 2023 · 17 comments · May be fixed by IFRCGo/go-frontend#2863
Assignees
Labels
DFS DFS team works on it geo Geospatial related task

Comments

@tovari
Copy link

tovari commented Jul 3, 2023

We need to display 'Kosovo' on the map and also add a specific disclaimer.

The typography should be somewhat lighter than the normal country names (e.g. font light version, or grey)
image

The map disclaimer text:
The name and boundaries of Kosovo are consistent with UN Security Council Resolution 1244 and the ICJ's Advisory Opinion on the Unilateral Declaration of Independence in Respect of Kosovo.

@frozenhelium, What are the display options for disclaimers? Can we show based on map view, zoom scale? Can we specify text in the disclaimer box based on the page url (e.g. showing it only on the map on the Serbia page)?

@tovari tovari added the geo Geospatial related task label Jul 3, 2023
@geohacker
Copy link

@tovari Should Kosovo appear only on the map embedded in GO or should it be available on all places where the default GO Mapbox Style is used?

I'm asking this because, by default, in the GO Mapbox style, we ignore any non-independent territory for admin-0 label.
image

Kosovo is filtered out because it's independent=false

If we need this across all maps, we should change in Mapbox Studio.
If we need this only on GO, we should ideally change on our GO Frontend code.

cc @davidmuchatiza

@geohacker
Copy link

@tovari @davidmuchatiza another question — is this only the case for Kosovo or should all non-independent admin0 labels show up on the map?

@tovari
Copy link
Author

tovari commented Jul 14, 2023

@geohacker, Kosovo should appear on all maps, so it could be added to the Mapbox Style.
We still need to investigate, if this should be applicable to other independent=false territories.

@geohacker
Copy link

Ok! I've added Kosovo with a slightly different style on Mapbox Studio style as well as opened a PR for the go-frontend maps IFRCGo/go-frontend#2863

image

We should probably work on getting the map styles matched up across the board but that's another ticket.

@tovari tovari closed this as completed Jan 22, 2024
@esario esario reopened this Apr 23, 2024
@esario
Copy link
Collaborator

esario commented Apr 23, 2024

Still open as PR IFRCGo/go-frontend#2863 is not approved.

image
(Screenshot from https://go.ifrc.org/emergencies/6952/details)

@frozenhelium frozenhelium transferred this issue from IFRCGo/go-frontend May 17, 2024
@frozenhelium frozenhelium self-assigned this May 17, 2024
@frozenhelium
Copy link
Member

frozenhelium commented May 21, 2024

@tovari Just making sure about the behavior here

  • Kosovo should not appear in the list of countries (since it is dependent, independent=false)
  • Kosovo label should appear in the map with slightly different style

Quick question, are there other similar dependent region that we should show in the map?

I think we should add an option to force view the label for dependent country in the admin panel instead of using hard coded id in the client. @tovari Let us know if this approach works. CC: @batpad @samshara @udaynwa

Also regarding,

What are the display options for disclaimers? Can we show based on map view, zoom scale? Can we specify text in the disclaimer box based on the page url (e.g. showing it only on the map on the Serbia page)?

Yes it should be possible to changes disclaimer for a specific country page. It should also be possible to show different disclaimer based on the zoom level and current view as well.

@geohacker
Copy link

I think we should add an option to force view the label for dependent country in the admin panel instead of using hard coded id in the client.

Yeah we might want to add a label_always_visible=True or so. But I'm not sure if this is a very common scenario.

@frozenhelium frozenhelium added the DFS DFS team works on it label May 28, 2024
@tovari
Copy link
Author

tovari commented May 28, 2024

correct @frozenhelium.
There will be other cases, but we need to discuss about each of them with IFRC Governance, what is the IFRC view. So, more special cases will come for sure (Western Sahara, Crimea, other disputed territories potentially)

@esario
Copy link
Collaborator

esario commented Jun 3, 2024

Also, if I search for Kosovo, I'm shown a list of (old) emergencies where the country = Kosovo. If I try to open any of them, I'm shown this error:

image

@udaynwa
Copy link

udaynwa commented Jun 4, 2024

Also, if I search for Kosovo, I'm shown a list of (old) emergencies where the country = Kosovo. If I try to open any of them, I'm shown this error:

image

We looked into this. Kosovo is responding with a null value for the bounding box. A quick fix would be to add the bounding box using the GO admin panel for Kosovo.

cc @szabozoltan69 @tovari

@szabozoltan69
Copy link
Collaborator

szabozoltan69 commented Jun 4, 2024

Ok @udaynwa , and what values should I use for Kosovo bounding box? Is this ok?

@szabozoltan69
Copy link
Collaborator

szabozoltan69 commented Jun 4, 2024

@udaynwa I've set a boundary box for Kosovo (via db).
The GO Admin has some issues about editing boundary boxes. Not clear why those RichText fields are there; in the old Django 3.2 there were no such fields.

@szabozoltan69
Copy link
Collaborator

szabozoltan69 commented Jun 4, 2024

Also, if I search for Kosovo, I'm shown a list of (old) emergencies where the country = Kosovo. If I try to open any of them, I'm shown this error:

image

This issue does not show up now after fixing the bbox in Kosovo.

@shreeyash07 shreeyash07 mentioned this issue Jun 5, 2024
6 tasks
@tovari
Copy link
Author

tovari commented Jun 25, 2024

The Kosovo label is still not visible on the map.
#1036 (comment)

@frozenhelium
Copy link
Member

frozenhelium commented Jun 27, 2024

@tovari it's now visible in the staging (v7.3.12)!
2024-06-27-183807

Please note that for now, we've switched to directly using the labels from mapbox style. So, it might have other regression which we'll test and verify. It also means that whenever anything is changed in the style, it'll be reflected in the GO.

@shraeyaa
Copy link

Both Serbia and Kosovo are selected when hovered on the map, till a certain zoom level.
image
cc @udaynwa @frozenhelium @samshara

@frozenhelium
Copy link
Member

frozenhelium commented Jul 1, 2024

Both Serbia and Kosovo are selected when hovered on the map, till a certain zoom level. image cc @udaynwa @frozenhelium @samshara

@davidmuchatiza I think, this needs to be fixed from mapbox studio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DFS DFS team works on it geo Geospatial related task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants