Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements.txt does not have versions #42

Closed
nolyn opened this issue Sep 13, 2021 · 2 comments · Fixed by #45
Closed

requirements.txt does not have versions #42

nolyn opened this issue Sep 13, 2021 · 2 comments · Fixed by #45

Comments

@nolyn
Copy link
Contributor

nolyn commented Sep 13, 2021

I tried to run rdplot with an venv using python 3.7 and installing requirements (in src/rdplot) using pip. it could open the application, but it crashed when selecting curves. Needed to downgrade matplotlib to 3.2.2.
Maybe we should add the version information to the requirements.txt. Ideally this should then match whatever exact versions are used to build pipx or windows installer packages.

@JensAc
Copy link
Member

JensAc commented Sep 14, 2021

I think this is only true for matplotlib. In setup.py matplotlib=3.4.2 is required and that should work as well. IMHO, we could add the version number for matplotlib.
Can you just check, whether 3.4.2 also works for you?

@dmehlem
Copy link
Member

dmehlem commented Oct 15, 2023

For me rdplot also crashes when selecting more than one curve, but I do not think the problem is related to the matplotlib version. The error message I get is:TypeError: setRowCount(self, rows: int): argument 1 has unexpected type 'float'

self.tableWidget.setRowCount(len(plot_data_collection)/len(config))

This can easily be fixed by a typecast to int().

However, tikzplotlib is currently not compatible with matplotlib>=3.8.0 as some private methods from matplotlib which tikzplotlib uses have been deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants