Refactor script to add safeguarding to flows for v2 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script uses idioms and conventions from Python which would be unusual and surprising to a JavaScript developer. Commented and unused code has been removed and certain sections have been rewritten for the sake of legibility. The behaviour of the script should be unchanged.
edmoss345
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Have tested this by running the pipeline before and after the refactor and after reviewing the output from the safeguarding step it looks like we get the same result. Therefore think this is good to merge as it appears to have the same functionality as the existing process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script uses idioms and conventions from Python which would be unusual and surprising to a JavaScript developer. Commented and unused code has been removed and certain sections have been rewritten for the sake of legibility. The behaviour of the script should be unchanged.