-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding csv archiving #20
Conversation
Three PRs are connected as this archive process required an update to the SA repo, the pipeline and the toolkit |
@istride I've made some changes as we discussed. Have pulled the 'archive' command into its own file so it is not part of the general pipeline. However, have been running into problems with the archive process, doesn't seem to save the csvs correctly when there is a ":" in the name of the sheet, but can't pin down where exactly it's failing and can't find a fix. Example output can be found in the SA repo PR. One for us to discuss |
I think the problem with the colon character (":") is specific to Windows. I managed to create an archive using the code in this PR, on my Linux machine, with colon characters intact. In the short-term, we can just use a Linux system to create the archive - via Docker, a VM or Github Actions. There is potentially a bigger problem here because I can't guarantee that there aren't characters that would not work in Linux file names. There a couple of ways we might deal with this:
|
c92fdff
to
89e981d
Compare
Changes to pipeline to accommodate archive functionality