Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite 'update_expiration_time' from JS to Python #16

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Rewrite 'update_expiration_time' from JS to Python #16

merged 1 commit into from
Sep 6, 2023

Conversation

istride
Copy link
Collaborator

@istride istride commented Sep 4, 2023

No description provided.

@istride istride requested a review from edmoss345 September 4, 2023 16:55
edmoss345
edmoss345 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@edmoss345 edmoss345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can use this as a template to move some of the other node.js steps as well

@istride istride force-pushed the replace_update_expiration_time branch from 3ad0afe to cddff65 Compare September 6, 2023 10:17
@istride istride merged commit 4ac4ac7 into main Sep 6, 2023
1 check passed
@istride istride deleted the replace_update_expiration_time branch September 6, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmoss345 edmoss345 edmoss345 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@istride @edmoss345