Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add input validation for passing both time and time_set to flowsheets #1459

Open
dallan-keylogic opened this issue Jul 26, 2024 · 1 comment
Open

Add input validation for passing both time and time_set to flowsheets #1459

dallan-keylogic opened this issue Jul 26, 2024 · 1 comment
Assignees
@dallan-keylogic
Labels
Priority:Low Low Priority Issue or PR

Comments

@dallan-keylogic
Copy link
Contributor

Presently, if you generate a flowsheet with config options for both time and time_set, it just uses time directly and ignores time_set. It should either generate an exception or log a warning that time_set is being ignored.
@dallan-keylogic dallan-keylogic self-assigned this Jul 26, 2024
@dallan-keylogic dallan-keylogic added the Priority:Low Low Priority Issue or PR label Jul 26, 2024
@ksbeattie
Copy link
Member

This is possibly related to #1464 or fixed together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dallan-keylogic dallan-keylogic

Labels
Priority:Low Low Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ksbeattie @dallan-keylogic