Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS Review - unit tests #41

Closed
mturiansky opened this issue Sep 11, 2022 · 1 comment
Closed

JOSS Review - unit tests #41

mturiansky opened this issue Sep 11, 2022 · 1 comment

Comments

@mturiansky
Copy link

As part of the JOSS review, unit tests are required to demonstrate the functionality of the code:

Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?

While automated tests are not required, I would highly suggest implementing them using github actions as it will help with the long-term maintainability of the code. Similarly, I would recommend setting up a linter (but that's optional of course).

I see that there is something implemented in tests/, but it includes hard-coded paths, which are specific to the maintainer's system. These fail when I run it on my computer.

@thohamm
Copy link
Member

thohamm commented Oct 10, 2022

fixed

@thohamm thohamm closed this as completed Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants