From 68c5b8e3fe7016bf065a0e2c0d4385515a3fcabc Mon Sep 17 00:00:00 2001
From: Shunguo Yan <shunguoy@us.ibm.com>
Date: Thu, 20 Apr 2023 10:22:43 -0500
Subject: [PATCH 1/2] update rule and test case #1336

---
 .../src/v2/aria/ARIADefinitions.ts            |  1 +
 .../body_attribute.html                       | 40 ++++++++++++++++++
 .../section copy.html                         | 42 -------------------
 3 files changed, 41 insertions(+), 42 deletions(-)
 create mode 100644 accessibility-checker-engine/test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/body_attribute.html
 delete mode 100644 accessibility-checker-engine/test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/section copy.html
diff --git a/accessibility-checker-engine/src/v2/aria/ARIADefinitions.ts b/accessibility-checker-engine/src/v2/aria/ARIADefinitions.ts
index c8b040852..47eedf466 100644
--- a/accessibility-checker-engine/src/v2/aria/ARIADefinitions.ts
+++ b/accessibility-checker-engine/src/v2/aria/ARIADefinitions.ts
@@ -1710,6 +1710,7 @@ export class ARIADefinitions {
         "body": {
             implicitRole: ["generic"],
             validRoles: null,
+            otherDisallowedAriaAttributes: ['aria-hidden'],
             globalAriaAttributesValid: true
         },
         "br": {
diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/body_attribute.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/body_attribute.html
new file mode 100644
index 000000000..618f45fc2
--- /dev/null
+++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/body_attribute.html
@@ -0,0 +1,40 @@
+<!DOCTYPE html>
+<html lang="en-US">
+  <head>
+    <title>Sandbox</title>
+    <meta charset="UTF-8" />
+  </head>
+
+  <body aria-hidden="true">
+    <main>
+      <h1>Test page</h1>
+    </main>
+    <script>
+      UnitTest = {
+        ruleIds: ["aria_attribute_allowed"],
+        results: [
+        {
+            "ruleId": "aria_attribute_allowed",
+            "value": [
+              "INFORMATION",
+              "FAIL"
+            ],
+            "path": {
+              "dom": "/html[1]/body[1]",
+              "aria": "/document[1]/generic[1]"
+            },
+            "reasonId": "Fail_invalid_implicit_role_attr",
+            "message": "The ARIA attributes \"aria-hidden\" are not valid for the element <body> with implicit ARIA role \"generic\"",
+            "messageArgs": [
+              "aria-hidden",
+              "body",
+              "generic"
+            ],
+            "apiArgs": [],
+            "category": "Accessibility"
+          }
+        ]
+      };
+    </script>
+  </body>
+</html>
diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/section copy.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/section copy.html
deleted file mode 100644
index 2be030999..000000000
--- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/section copy.html	
+++ /dev/null
@@ -1,42 +0,0 @@
-<!DOCTYPE html>
-<html lang="en-US">
-  <head>
-    <title>Sandbox</title>
-    <meta charset="UTF-8" />
-  </head>
-
-  <body>
-    <main>
-      <h1>Test page</h1>
-      <section role="group">
-        Hello
-      </section>
-    </main>
-    <script>
-      UnitTest = {
-        ruleIds: ["aria_semantics_role"],
-        results: [
-          {
-            "ruleId": "aria_semantics_role",
-            "value": [
-              "INFORMATION",
-              "PASS"
-            ],
-            "path": {
-              "dom": "/html[1]/body[1]/main[1]/section[1]",
-              "aria": "/document[1]/main[1]/group[1]"
-            },
-            "reasonId": "Pass_0",
-            "message": "Rule Passed",
-            "messageArgs": [
-              "group",
-              "section"
-            ],
-            "apiArgs": [],
-            "category": "Accessibility"
-          }
-        ]
-      };
-    </script>
-  </body>
-</html>

From 602a5adba0d83712926e0184d03bb42f077d0310 Mon Sep 17 00:00:00 2001
From: Shunguo Yan <shunguoy@us.ibm.com>
Date: Thu, 20 Apr 2023 14:54:07 -0500
Subject: [PATCH 2/2] add search element support #1336

---
 .../src/v2/aria/ARIADefinitions.ts            |   5 +
 .../search_role_attribute.html                | 175 ++++++++++++++++++
 2 files changed, 180 insertions(+)
 create mode 100644 accessibility-checker-engine/test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/search_role_attribute.html

diff --git a/accessibility-checker-engine/src/v2/aria/ARIADefinitions.ts b/accessibility-checker-engine/src/v2/aria/ARIADefinitions.ts
index 47eedf466..d685f2d26 100644
--- a/accessibility-checker-engine/src/v2/aria/ARIADefinitions.ts
+++ b/accessibility-checker-engine/src/v2/aria/ARIADefinitions.ts
@@ -2052,6 +2052,11 @@ export class ARIADefinitions {
             validRoles: null,
             globalAriaAttributesValid: false
         },
+        "search": {
+            implicitRole: ['search'],
+            validRoles: ['search', 'form', 'group', 'none', 'presentation', 'region'],
+            globalAriaAttributesValid: true
+        },
         "slot": {
             implicitRole: null,
             validRoles: null,
diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/search_role_attribute.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/search_role_attribute.html
new file mode 100644
index 000000000..ad35b39c8
--- /dev/null
+++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/search_role_attribute.html
@@ -0,0 +1,175 @@
+<!DOCTYPE html>
+<html lang="en-US">
+  <head>
+    <title>Sandbox</title>
+    <meta charset="UTF-8" />
+  </head>
+
+  <body>
+    <main>
+      <search>
+        <label for=s>Site</label>
+        <input type=search id=s>
+        <button>Go!</button>
+      </search>
+      <search role="search" aria-checked="true"> </search>
+      <search role="alert" > </search>
+      <search role="form" aria-atomic="true"> </search>
+    </main>
+    <script>
+      UnitTest = {
+        ruleIds: ["aria_attribute_allowed", "aria_semantics_role", "aria_role_redundant"],
+        results: [
+        {
+            "ruleId": "aria_role_redundant",
+            "value": [
+              "INFORMATION",
+              "FAIL"
+            ],
+            "path": {
+              "dom": "/html[1]/body[1]/main[1]/search[2]",
+              "aria": "/document[1]/main[1]/search[2]"
+            },
+            "reasonId": "fail_redundant",
+            "message": "The explicitly-assigned ARIA role \"search\" is redundant with the implicit role of the element <search>",
+            "messageArgs": [
+              "search",
+              "search"
+            ],
+            "apiArgs": [],
+            "category": "Accessibility"
+          },
+          {
+            "ruleId": "aria_semantics_role",
+            "value": [
+              "INFORMATION",
+              "PASS"
+            ],
+            "path": {
+              "dom": "/html[1]/body[1]/main[1]/search[2]",
+              "aria": "/document[1]/main[1]/search[2]"
+            },
+            "reasonId": "Pass_0",
+            "message": "Rule Passed",
+            "messageArgs": [
+              "search",
+              "search"
+            ],
+            "apiArgs": [],
+            "category": "Accessibility"
+          },
+          {
+            "ruleId": "aria_attribute_allowed",
+            "value": [
+              "INFORMATION",
+              "FAIL"
+            ],
+            "path": {
+              "dom": "/html[1]/body[1]/main[1]/search[2]",
+              "aria": "/document[1]/main[1]/search[2]"
+            },
+            "reasonId": "Fail_invalid_role_attr",
+            "message": "The ARIA attributes \"aria-checked\" are not valid for the element <search> with ARIA role \"search\"",
+            "messageArgs": [
+              "aria-checked",
+              "search",
+              "search"
+            ],
+            "apiArgs": [],
+            "category": "Accessibility"
+          },
+          {
+            "ruleId": "aria_role_redundant",
+            "value": [
+              "INFORMATION",
+              "PASS"
+            ],
+            "path": {
+              "dom": "/html[1]/body[1]/main[1]/search[3]",
+              "aria": "/document[1]/main[1]/alert[1]"
+            },
+            "reasonId": "pass",
+            "message": "An explicitly-assigned ARIA role is not redundant with the implicit role of the element",
+            "messageArgs": [],
+            "apiArgs": [],
+            "category": "Accessibility"
+          },
+          {
+            "ruleId": "aria_semantics_role",
+            "value": [
+              "INFORMATION",
+              "FAIL"
+            ],
+            "path": {
+              "dom": "/html[1]/body[1]/main[1]/search[3]",
+              "aria": "/document[1]/main[1]/alert[1]"
+            },
+            "reasonId": "Fail_1",
+            "message": "The ARIA role 'alert' is not valid for the element <search>",
+            "messageArgs": [
+              "alert",
+              "search"
+            ],
+            "apiArgs": [],
+            "category": "Accessibility"
+          },
+          {
+            "ruleId": "aria_role_redundant",
+            "value": [
+              "INFORMATION",
+              "PASS"
+            ],
+            "path": {
+              "dom": "/html[1]/body[1]/main[1]/search[4]",
+              "aria": "/document[1]/main[1]/form[1]"
+            },
+            "reasonId": "pass",
+            "message": "An explicitly-assigned ARIA role is not redundant with the implicit role of the element",
+            "messageArgs": [],
+            "apiArgs": [],
+            "category": "Accessibility"
+          },
+          {
+            "ruleId": "aria_semantics_role",
+            "value": [
+              "INFORMATION",
+              "PASS"
+            ],
+            "path": {
+              "dom": "/html[1]/body[1]/main[1]/search[4]",
+              "aria": "/document[1]/main[1]/form[1]"
+            },
+            "reasonId": "Pass_0",
+            "message": "Rule Passed",
+            "messageArgs": [
+              "form",
+              "search"
+            ],
+            "apiArgs": [],
+            "category": "Accessibility"
+          },
+          {
+            "ruleId": "aria_attribute_allowed",
+            "value": [
+              "INFORMATION",
+              "PASS"
+            ],
+            "path": {
+              "dom": "/html[1]/body[1]/main[1]/search[4]",
+              "aria": "/document[1]/main[1]/form[1]"
+            },
+            "reasonId": "Pass",
+            "message": "ARIA attributes are valid for the element and ARIA role",
+            "messageArgs": [
+              "aria-atomic",
+              "search",
+              "form"
+            ],
+            "apiArgs": [],
+            "category": "Accessibility"
+          }
+        ]
+      };
+    </script>
+  </body>
+</html>
