Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example for using the async producer with goroutines #326

Merged
merged 1 commit into from
Mar 10, 2015
Merged

Add an example for using the async producer with goroutines #326

merged 1 commit into from
Mar 10, 2015

Conversation

wvanbergen
Copy link
Contributor

@Shopify/kafka

@wvanbergen
Copy link
Contributor Author

Partially fixes #323

@eapache
Copy link
Contributor

eapache commented Mar 9, 2015

LGTM

eapache
eapache reviewed Mar 10, 2015
View reviewed changes
producer_test.go
log.Println("Failed to produce message", err)
errors++
case <-signals:
break
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the failing test (go vet) caught: you need to break the outer loop, this will just break the select statement by default

wvanbergen added a commit that referenced this pull request Mar 10, 2015
@wvanbergen
Merge pull request #326 from Shopify/producer_example
14bae79 
Add an example for using the async producer with goroutines
@wvanbergen wvanbergen merged commit 14bae79 into master Mar 10, 2015
@wvanbergen wvanbergen deleted the producer_example branch March 10, 2015 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wvanbergen @eapache