Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building fails on windows with race flag #1197

Closed
heppu opened this issue Oct 19, 2018 · 2 comments
Closed

Building fails on windows with race flag #1197

heppu opened this issue Oct 19, 2018 · 2 comments
Labels
stale Issues and pull requests without any recent activity

Comments

@heppu
Copy link

heppu commented Oct 19, 2018

Versions

Sarama Version: 1.19.0
Go Version: go1.11 windows/amd64

Go env
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\user\AppData\Local\go-build
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\git\go
set GOPROXY=
set GORACE=
set GOROOT=C:\Go
set GOTMPDIR=
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\user\AppData\Local\Temp\go-build404622078=/tmp/go-build -gno-record-gcc-switches
Logs
2018/10/19 09:57:57 error reading input: EOF
FAIL    user/kafka [build failed]
Error: Tests failed.
Problem Description

When building package which imports sarama on windows with race flag using Go 1.11 build fails. I wasn't able to reproduce this with linux+go 1.11 or windows+go 1.10.

Command to reproduce:

go test -race -v ./...

Test case to reproduce:

package kafka_test
 
import (
    "testing"
 
    _ "github.com/Shopify/sarama"
)
 
func TestEOF(t *testing.T) {}
@d1egoaz
Copy link
Contributor

d1egoaz commented Aug 22, 2019

do you still have this problem @heppu?

also, current sarama added support to zstd (cgo) which will make things harder to build in windows #1215

@ghost
Copy link

ghost commented Feb 21, 2020

Thank you for taking the time to raise this issue. However, it has not had any activity on it in the past 90 days and will be closed in 30 days if no updates occur.
Please check if the master branch has already resolved the issue since it was raised. If you believe the issue is still valid and you would like input from the maintainers then please comment to ask for it to be reviewed.

@ghost ghost added the stale Issues and pull requests without any recent activity label Feb 21, 2020
@ghost ghost closed this as completed Mar 22, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues and pull requests without any recent activity
Projects
None yet
Development

No branches or pull requests

2 participants