Library works from Python 2.7+ (Compatible with all 3.x versions) #9
Conversation
|
@Tzur-i can I get a review on this please? |
| @@ -24,7 +24,7 @@ | |||
|
|
|||
| import json | |||
| from socket import getfqdn | |||
| from bunch import Bunch | |||
| from munch import Munch | |||
There was a problem hiding this comment.
Why Munch?
A Replacement like this requires extensive testing.
What's the benefit of this?
There was a problem hiding this comment.
I don't believe that Bunch is still supported, and it is incompatible with Python 3.x. All of my tests failed with Bunch in Python 3. It appears that Infinidat forked Bunch and created Munch.
| @@ -189,7 +194,7 @@ class TerminationDetectingXMLParser(object): | |||
|
|
|||
| def __init__(self): | |||
| self.tree_builder = _TerminationDetectingTreeBuilder() | |||
| self.xml_tree_builder = et.XMLTreeBuilder(target=self.tree_builder) | |||
| self.xml_tree_builder = et.XMLParser(target=self.tree_builder) | |||
There was a problem hiding this comment.
XMLParser will also require extensive testing. I know that TreeBuilder is old, but what's the benefit?
There was a problem hiding this comment.
XMLTreeBuilder did not appear to exist in Python 3. XMLParser should be used instead; I can add the backwards compatibility try/except stated in the documentation http://effbot.org/elementtree/elementtree-xmlparser.htm
|
Hi, |
This change is