Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit jobs in helm chart #41

Closed
molepigeon opened this issue Dec 3, 2018 · 2 comments
Closed

Revisit jobs in helm chart #41

molepigeon opened this issue Dec 3, 2018 · 2 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@molepigeon
Copy link
Member

When we first launched, Helm didn't support a number of things that we needed, like creating custom resource definitions. So we created a number of Jobs in the chart that spun up a kubectl pod to apply yamls against the cluster.

I believe that the things we need are now supported, and so we can revisit the chart and try to create them in-line rather than spin up a kubectl pod. This would improve the experience when the chart fails to install, since there won't be jobs lying around that prevent you from re-running the chart installation.

@laeven
Copy link

laeven commented Feb 4, 2019

Hello, I submitted a PR (#50) In hopes to help out, I would appreciate any feedback.
There were some limitations detailed in the helm Github when trying to deal with this such as "Resources generated by helm hooks are not handled during resource clean up" which required the use of jobs for creation. There's also limitations when performing upgrades which I am currently investigating, but I wanted some opinions and help on those parts.

@sjhx sjhx self-assigned this Jan 22, 2020
@molepigeon
Copy link
Member Author

Fixed by #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants