Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RedactSecrets): add additional keywords to be redacted #191

Merged
merged 1 commit into from
Aug 22, 2023
Merged

fix(RedactSecrets): add additional keywords to be redacted #191

merged 1 commit into from
Aug 22, 2023

Conversation

padamstx
Copy link
Member

Fixes: #190

@padamstx padamstx self-assigned this Aug 21, 2023
@padamstx padamstx requested review from dpopp07 and pyrooka August 21, 2023 21:57
@padamstx padamstx mentioned this pull request Aug 21, 2023
Closed
pyrooka
pyrooka approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dpopp07
dpopp07 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@padamstx padamstx merged commit d176568 into main Aug 22, 2023
@padamstx padamstx deleted the redact-secrets branch August 22, 2023 14:17
ibm-devx-sdk pushed a commit that referenced this pull request Aug 22, 2023
@semantic-release-bot
chore(release): 5.14.1 release notes [skip ci]
030f198 
## [5.14.1](v5.14.0...v5.14.1) (2023-08-22)

### Bug Fixes

* **RedactSecrets:** add additional keywords to be redacted ([#191](#191)) ([d176568](d176568)), closes [#190](#190)
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 5.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrooka pyrooka pyrooka approved these changes

@dpopp07 dpopp07 dpopp07 approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the RedactSecrets Regex to Support Satellite Storage Template Secret Parameter Names
4 participants
@padamstx @ibm-devx-sdk @dpopp07 @pyrooka