Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recognize vendor-specific JSON mimetypes #138

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Conversation

padamstx
Copy link
Member

This commit modifies the Go core response-handling code
so that it recognizes vendor-specific JSON-based mimetypes
(e.g. application/vnd.docker.distribution.manifest.v2+json)
as being equivalent to "application/json" when deciding how
to unmarshal an operation response body.
Prior to this change, the Go core would treat such a response
as an error.

This commit modifies the Go core response-handling code
so that it recognizes vendor-specific JSON-based mimetypes
(e.g. application/vnd.docker.distribution.manifest.v2+json)
as being equivalent to "application/json" when deciding how
to unmarshal an operation response body.
Prior to this change, the Go core would treat such a response
as an error.
@padamstx padamstx self-assigned this Sep 14, 2021
@padamstx padamstx requested review from dpopp07 and pyrooka September 14, 2021 22:55
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@padamstx padamstx merged commit fb2c14a into main Sep 15, 2021
@padamstx padamstx deleted the vendor-json-mimetype branch September 15, 2021 22:30
ibm-devx-sdk pushed a commit that referenced this pull request Sep 15, 2021
## [5.6.5](v5.6.4...v5.6.5) (2021-09-15)

### Bug Fixes

* recognize vendor-specific JSON mimetypes ([#138](#138)) ([fb2c14a](fb2c14a))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 5.6.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants