feat(AuthType): Ignore case of authType

IBM · Sep 10, 2019 · 5f14b25 · 5f14b25
1 parent 199f371
commit 5f14b25
Showing 1 changed file with 25 additions and 22 deletions.
diff --git a/src/IBM.Cloud.SDK.Core/Authentication/ConfigBasedAuthenticatorFactory.cs b/src/IBM.Cloud.SDK.Core/Authentication/ConfigBasedAuthenticatorFactory.cs
@@ -21,12 +21,15 @@
 using IBM.Cloud.SDK.Core.Authentication.Iam;
 using IBM.Cloud.SDK.Core.Authentication.NoAuth;
 using IBM.Cloud.SDK.Core.Util;
+using System;
 using System.Collections.Generic;
 
 namespace IBM.Cloud.SDK.Core.Authentication
 {
     public class ConfigBasedAuthenticatorFactory
     {
+        public static string ErrorMessageAuthTypeUnknown = "Unrecognized authentication type: %s";
+
         public static Authenticator GetAuthenticator(string serviceName)
         {
             Authenticator authenticator = null;
@@ -77,29 +80,29 @@ private static Authenticator CreateAuthenticator(Dictionary<string, string> prop
                 authType = Authenticator.AuthTypeIam;
             }
 
-            switch (authType)
+            if (authType.Equals(Authenticator.AuthTypeNoAuth, StringComparison.InvariantCultureIgnoreCase))
             {
-                case Authenticator.AuthTypeNoAuth:
-                    authenticator = new NoAuthAuthenticator(props);
-                    break;
-
-                case Authenticator.AuthTypeBasic:
-                    authenticator = new BasicAuthenticator(props);
-                    break;
-
-                case Authenticator.AuthTypeIam:
-                    authenticator = new IamAuthenticator(props);
-                    break;
-
-                case Authenticator.AuthTypeCp4d:
-                    authenticator = new CloudPakForDataAuthenticator(props);
-                    break;
-
-                case Authenticator.AuthTypeBearer:
-                    authenticator = new BearerTokenAuthenticator(props);
-                    break;
-                default:
-                    break;
+                authenticator = new NoAuthAuthenticator(props);
+            }
+            else if (authType.Equals(Authenticator.AuthTypeBasic, StringComparison.InvariantCultureIgnoreCase))
+            {
+                authenticator = new BasicAuthenticator(props);
+            }
+            else if (authType.Equals(Authenticator.AuthTypeIam, StringComparison.InvariantCultureIgnoreCase))
+            {
+                authenticator = new IamAuthenticator(props);
+            }
+            else if (authType.Equals(Authenticator.AuthTypeCp4d, StringComparison.InvariantCultureIgnoreCase))
+            {
+                authenticator = new CloudPakForDataAuthenticator(props);
+            }
+            else if (authType.Equals(Authenticator.AuthTypeBearer, StringComparison.InvariantCultureIgnoreCase))
+            {
+                authenticator = new BearerTokenAuthenticator(props);
+            }
+            else
+            {
+                throw new ArgumentException(string.Format(ErrorMessageAuthTypeUnknown, authType));
             }
 
             return authenticator;