Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests should include all major Yarn versions #302

Closed
sargunv opened this issue Jan 9, 2023 · 2 comments
Closed

Tests should include all major Yarn versions #302

sargunv opened this issue Jan 9, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sargunv
Copy link
Contributor

sargunv commented Jan 9, 2023

Currently the tests include Yarn v1 and v2. They should also include v3, and perhaps v4 rc builds?

Since v2 and later (Berry) are all very similar, potentially refactor the test code to reuse the same tests for all major Berry versions.

@quinnturner quinnturner added enhancement New feature or request good first issue Good for newcomers labels Jan 9, 2023
@arcanis
Copy link

arcanis commented Oct 10, 2023

Note that someone mentioned a bug when used with the 4.0: yarnpkg/berry#5781 (comment) (we rewrote the command to use a different npm endpoint, which unfortunately doesn't return the same data; you should probably test v1, v3, and v4).

@quinnturner
Copy link
Member

I have added test cases for Yarn v2 and v3 in audit-ci's latest v7 release. We currently do not support Yarn v4, as documented in my comment here: #332 (comment).

If you wish to support Yarn v4 and have solid use-cases, please let me know by commenting on that thread!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants