Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce fhir-server-spi #2870

Merged
merged 2 commits into from
Oct 21, 2021
Merged

Introduce fhir-server-spi #2870

merged 2 commits into from
Oct 21, 2021

Conversation

lmsurpre
Copy link
Member

Currently, this module houses the SPI-related classes for:

  • Interceptors
  • Custom Operations

As part of that effort, I moved the Interaction enum from FHIRRestHelper
to its interface, FHIRResourceHelpers.

I updated fhir-smart to depend on fhir-server-spi instead of
fhir-server.

I also updated all fhir-operation modules to depend on a
'provided'-scope fhir-server-spi instead of fhir-server, with the
following exceptions:

  1. fhir-operation-erase because that one still depends on
    RestAuditLogger which I decided not to move into the spi module
  2. fhir-operation-term-cache because that depends on
    ServerRegistryResourceProvider (to clear its internal cache)

Signed-off-by: Lee Surprenant [email protected]

@lmsurpre lmsurpre added the new-module Flag for identifying PRs that introduce a new module (and therefor require manual work for release) label Oct 19, 2021
Currently, this module houses the SPI-related classes for:
* Interceptors
* Custom Operations

As part of that effort, I moved the Interaction enum from FHIRRestHelper
to its interface, FHIRResourceHelpers.

I updated fhir-smart to depend on fhir-server-spi instead of
fhir-server.

I also updated all fhir-operation modules to depend on a
'provided'-scope fhir-server-spi instead of fhir-server, with the
following exceptions:
1. fhir-operation-erase because that one still depends on
RestAuditLogger which I decided not to move into the spi module
2. fhir-operation-term-cache because that depends on
ServerRegistryResourceProvider (to clear its internal cache)

Signed-off-by: Lee Surprenant <[email protected]>
Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - save for the fhir-parent change

Copy link
Contributor

@michaelwschroeder michaelwschroeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@punktilious punktilious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmsurpre lmsurpre merged commit a866d19 into issue-2777 Oct 21, 2021
@lmsurpre lmsurpre deleted the fhir-server-spi branch October 21, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-module Flag for identifying PRs that introduce a new module (and therefor require manual work for release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants