-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce fhir-server-spi #2870
Conversation
dc455be
to
4d4d306
Compare
Currently, this module houses the SPI-related classes for: * Interceptors * Custom Operations As part of that effort, I moved the Interaction enum from FHIRRestHelper to its interface, FHIRResourceHelpers. I updated fhir-smart to depend on fhir-server-spi instead of fhir-server. I also updated all fhir-operation modules to depend on a 'provided'-scope fhir-server-spi instead of fhir-server, with the following exceptions: 1. fhir-operation-erase because that one still depends on RestAuditLogger which I decided not to move into the spi module 2. fhir-operation-term-cache because that depends on ServerRegistryResourceProvider (to clear its internal cache) Signed-off-by: Lee Surprenant <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - save for the fhir-parent change
4d4d306
to
4e62a94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Lee Surprenant <[email protected]>
73a65d2
to
cae989f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Currently, this module houses the SPI-related classes for:
As part of that effort, I moved the Interaction enum from FHIRRestHelper
to its interface, FHIRResourceHelpers.
I updated fhir-smart to depend on fhir-server-spi instead of
fhir-server.
I also updated all fhir-operation modules to depend on a
'provided'-scope fhir-server-spi instead of fhir-server, with the
following exceptions:
RestAuditLogger which I decided not to move into the spi module
ServerRegistryResourceProvider (to clear its internal cache)
Signed-off-by: Lee Surprenant [email protected]