Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query params benchmark #20

Merged
merged 5 commits into from
Jan 25, 2019
Merged

Query params benchmark #20

merged 5 commits into from
Jan 25, 2019

Conversation

djones6
Copy link
Contributor

@djones6 djones6 commented Jan 24, 2019

This adds a simple benchmark which exercises query parameters (echoing back a supplied message). It purposefully does little else in order to evaluate the performance overhead compared to a static 'Hello World' plaintext response.

@djones6 djones6 requested a review from ianpartridge January 24, 2019 10:09
@djones6 djones6 added this to the 2019.02 milestone Jan 24, 2019
@djones6 djones6 mentioned this pull request Jan 24, 2019
Merged
ianpartridge
ianpartridge reviewed Jan 24, 2019
View reviewed changes
Copy link

@ianpartridge ianpartridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, great.

Bench-Kitura-Core/2.3.2/Package.swift Outdated Show resolved Hide resolved
Bench-Kitura-Core/latest/Package.swift Outdated Show resolved Hide resolved
@djones6 djones6 merged commit 295f1e9 into master Jan 25, 2019
@djones6 djones6 deleted the QueryParams branch January 25, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianpartridge ianpartridge ianpartridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2019.02
Development

Successfully merging this pull request may close these issues.
2 participants
@djones6 @ianpartridge