Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fides_meta and meta attributes to base models #96

Closed
pattisdr opened this issue Dec 9, 2022 · 0 comments
Closed

Add fides_meta and meta attributes to base models #96

pattisdr opened this issue Dec 9, 2022 · 0 comments
Labels

Comments

@pattisdr
Copy link
Contributor

pattisdr commented Dec 9, 2022

Is your feature request related to a specific problem?

Reticketed from https://github.com/ethyca/fideslang/issues/94, which handled this for Datasets.

We want to more broadly unify some of the -ctl and -ops fields. Ops wasn't really concerned with updating Systems or Organizations in the past, but as we move to share models in between these products, it would be good to share the underlying attributes.

  • Update Organization to use fides_meta instead of fidesctl_meta
  • Update System to use fides_meta instead of fidesctl_meta
  • Add meta fields to Organization and System.

Are there other models we need to consider?

Note:
Downstream fides writes system information to fidesctl_meta. This will need to switch to fides_meta. Likewise, downstream database tables will need to rename the fidesctl_meta attribute.

A description of what the problem is.
Ex. I'm always frustrated when [...]

Describe the solution you'd like

A description of what you want to happen.

Describe alternatives you've considered, if any

A description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants