Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulating CTF with pre-CTF noise doesn't work #882

Open
jamesmkrieger opened this issue Jan 17, 2025 · 1 comment · May be fixed by #883
Open

Simulating CTF with pre-CTF noise doesn't work #882

jamesmkrieger opened this issue Jan 17, 2025 · 1 comment · May be fixed by #883
Assignees

Comments

@jamesmkrieger
Copy link
Contributor

First I had a problem that I fixed in #881. Now there's another one:

00001: Traceback (most recent call last):
00002: File "/home/spa/scipion3/scipion-pyworkflow/pyworkflow/protocol/protocol.py", line 207, in run
00003: self._run()
00004: File "/home/spa/scipion3/scipion-pyworkflow/pyworkflow/protocol/protocol.py", line 257, in _run
00005: resultFiles = self._runFunc()
00006: File "/home/spa/scipion3/scipion-pyworkflow/pyworkflow/protocol/protocol.py", line 253, in _runFunc
00007: return self._func(*self._args)
00008: File "/home/spa/scipion3/xmipp-bundle/src/scipion-em-xmipp/xmipp3/protocols/protocol_simulate_ctf.py", line 124, in simulateStep
00009: I.setData(Idata+self.noiseBefore.get()*np.random.Generator.normal(size=Idata.shape))
00010: TypeError: descriptor 'normal' of 'numpy.random._generator.Generator' object needs an argument
00011: Protocol failed: descriptor 'normal' of 'numpy.random._generator.Generator' object needs an argument

@jamesmkrieger jamesmkrieger self-assigned this Jan 21, 2025
@jamesmkrieger
Copy link
Contributor Author

Probably this was an old functionality that was lost since numpy 1.17 or so. We now have to initialise the generator first and I have a fix to do that.

@jamesmkrieger jamesmkrieger linked a pull request Jan 21, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant