Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit sqlite database implementation when sqlite is not available #173

Closed
DRMacIver opened this issue Sep 25, 2015 · 4 comments
Closed

Omit sqlite database implementation when sqlite is not available #173

DRMacIver opened this issue Sep 25, 2015 · 4 comments
Labels
enhancement it's not broken, but we want it to be better

Comments

@DRMacIver
Copy link
Member

DRMacIver commented Sep 25, 2015

Some platforms ship the sqlite library separately from core Python (bsd) or don't implement it at all (Jython). This is annoying, because it means Hypothesis doesn't work because it tries to import sqlite3.

This is particularly annoying these days because we don't even really need the sqlite implementation.

We could either check for availability and not provide that implementation in that case, or we could just deprecate the silly thing and move on.

@DRMacIver DRMacIver added the enhancement it's not broken, but we want it to be better label Sep 25, 2015
@Zac-HD
Copy link
Member

Zac-HD commented May 11, 2017

The database docs suggest that this has been implemented, and that the sqlite3 option may even be removed in future. If this is not the case, I think we have a docs bug instead.

@Zac-HD Zac-HD closed this as completed May 11, 2017
@DRMacIver DRMacIver reopened this May 11, 2017
@DRMacIver
Copy link
Member Author

So this has been implemented in the sense that we now don't use sqlite by default, but we still import it unconditionally so things will still break if you don't have it. I'll update the ticket accordingly.

@DRMacIver DRMacIver changed the title Provide fallback database implementation when sqlite is not available Omit sqlite database implementation when sqlite is not available May 11, 2017
@Zac-HD
Copy link
Member

Zac-HD commented May 12, 2017

It actually looks like it'll be a pretty easy fix to database.py, plus some corrections to documentation (including docstrings for settings; do a whole-project search).

Will we want to start running on Jython in CI?

@DRMacIver
Copy link
Member Author

Will we want to start running on Jython in CI?

Jython support is substantially more complicated than just this one thing, and TBH I'm not sure it's worth it. If someone wants to put in the work to make Hypothesis work on Jython we could certainly start running it in CI, but I'm not sure there's a good reason to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement it's not broken, but we want it to be better
Projects
None yet
Development

No branches or pull requests

2 participants