Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to link to privacy statement in the "About" popup #1408

Closed
johnaohara opened this issue Mar 5, 2024 · 1 comment · Fixed by #1437
Closed

Add functionality to link to privacy statement in the "About" popup #1408

johnaohara opened this issue Mar 5, 2024 · 1 comment · Fixed by #1437
Assignees

Comments

@johnaohara
Copy link
Member

Describe the bug

To comply with legal requirements, a privacy statement should be made available to end users. This can change between installations, so the privacy statement should be a configurable URL that can displayed as a link in the about popup

@lampajr
Copy link
Member

lampajr commented Mar 6, 2024

Hey @johnaohara, if I correctly understood this would be about adding new "row" here:
image
where we would show the privacy stmt configurable URL.

Here two doubts:

  • I still do not have fully clear how you were thinking about its configurability 😕
    • I was thinking to make the URL configurable through env variables/java props in backend and return it as part of the VersionInfo object [1], wdyt?
  • Do we already have a default to use?

[1]

public VersionInfo version() {
VersionInfo info = new VersionInfo();
info.version = Version.VERSION;
info.startTimestamp = startTimestamp;
return info;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants