Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToWords - Hebrew language #145

Closed
hmemcpy opened this issue Apr 9, 2014 · 4 comments
Closed

ToWords - Hebrew language #145

hmemcpy opened this issue Apr 9, 2014 · 4 comments

Comments

@hmemcpy
Copy link
Contributor

hmemcpy commented Apr 9, 2014

In Hebrew, there are both masculine and feminine forms of numbers, e.g. 1 can be either אחת ("achat", feminine) or אחד ("echad", masculine), depending on the preceding or following word.

I wonder how to address this issue in implementing ToWords() Hebrew extension? An additional overload, accepting this sounds reasonable, but not all languages have this...

Ideas?

@synhershko
Copy link

You have to use a dictionary for that, and you can use hspell and my C# code that reads it and allows to figure out if a word is masculine or feminine. Caveat: it's AGPL3 licensed. See: https://github.com/synhershko/HebMorph/tree/master/dotNet/HebMorph/HSpell

But personally I don't think it is worth the effort...

@hmemcpy
Copy link
Contributor Author

hmemcpy commented Apr 9, 2014

As this is a simple ToWords(this int number) extension, I don't suppose I need to go all the way of figuring out the form. Maybe I can settle for an enum after all. @SLaks did something very similar: https://github.com/ShomreiTorah/Libraries/blob/master/ShomreiTorah.Common/Extensions.cs#L700

@hazzik
Copy link
Member

hazzik commented Apr 9, 2014

There is #74 issue, which is about to introduce GrammaticalGender enum and @mexx did this in #147

Also it is related to #149

@MehdiK
Copy link
Member

MehdiK commented Apr 12, 2014

#147 and #149 are now both merged and provide a great infrastructure for this.

@MehdiK MehdiK closed this as completed Apr 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants