-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: OPTIC-1178: Possible LS Memory Leak #6704
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…put that contains objects
web/libs/datamanager/src/components/MainView/GridView/GridView.jsx
Outdated
Show resolved
Hide resolved
/git merge develop
|
/git merge develop
|
/git merge develop
|
Block
andElem
elements to div/span or what ever provided tag and usecn
to preserve classnames/stylingweb/libs/datamanager/src/components/Common/Form/Form.jsx
slight refactor to figure out class name once and apply it in loopweb/libs/datamanager/src/components/MainView/GridView/GridView.jsx
added an onChange to reduce console error noise - no negative impactweb/libs/datamanager/src/stores/AppStore.js
yield load task replaced with a promise.then - this addressed and error in console when moving fast enough about potential memory leaksweb/libs/datamanager/src/utils/bem.tsx
took out some properties being assigned which don’t seem to be used - wrapped in FF just in caseweb/libs/editor/src/components/App/App.jsx
added a check for taskHistory length as it was causing an error when clicked - if button doesn’t work no need to display itweb/libs/editor/src/components/BottomBar/Controls.tsx
added keys to reduce console error noise due to keys not setweb/libs/editor/src/components/InstructionsModal/InstructionsModal.tsx
replaced visible with open to reduce noise in consolePR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
resolving issues that are leading to memory leaks which reduce performance as the user works with application over time