Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OPTIC-1178: Possible LS Memory Leak #6704

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

yyassi-heartex
Copy link
Contributor

@yyassi-heartex yyassi-heartex commented Nov 22, 2024

  • Converted a number of Block and Elem elements to div/span or what ever provided tag and use cn to preserve classnames/styling
    • this is the primary improvement in this PR
  • Updated image cell and Annotation Preview to use div with background image instead of img element - wrapped in FF
    • not sure this helps - might undo this one
  • web/libs/datamanager/src/components/Common/Form/Form.jsx slight refactor to figure out class name once and apply it in loop
  • web/libs/datamanager/src/components/MainView/GridView/GridView.jsx added an onChange to reduce console error noise - no negative impact
  • Cleared out console logging for interfaces to reduce noise and to prevent array from logging in console which can have an impact on performance
  • web/libs/datamanager/src/stores/AppStore.js yield load task replaced with a promise.then - this addressed and error in console when moving fast enough about potential memory leaks
  • web/libs/datamanager/src/utils/bem.tsx took out some properties being assigned which don’t seem to be used - wrapped in FF just in case
  • web/libs/editor/src/components/App/App.jsx added a check for taskHistory length as it was causing an error when clicked - if button doesn’t work no need to display it
  • web/libs/editor/src/components/BottomBar/Controls.tsx added keys to reduce console error noise due to keys not set
  • web/libs/editor/src/components/InstructionsModal/InstructionsModal.tsx replaced visible with open to reduce noise in console

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

resolving issues that are leading to memory leaks which reduce performance as the user works with application over time

@github-actions github-actions bot added the fix label Nov 22, 2024
Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit 86bc33e
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/675c801a990a380008be1fd4
😎 Deploy Preview https://deploy-preview-6704--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit 86bc33e
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/675c801a82b55a0008bc34b6
😎 Deploy Preview https://deploy-preview-6704--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Dec 12, 2024

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/libs/frontend-test/src/helpers/utils/fixLSParams.ts

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Dec 13, 2024

/git merge develop

Workflow run
Successfully merged: 7 files changed, 190 insertions(+), 34 deletions(-)

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Dec 13, 2024

/git merge develop

Workflow run
Successfully merged: 4 files changed, 480 insertions(+), 4 deletions(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants