fix: encoding of quotes in Page Sharer URL

[cbdm]

Purpose

Change the way url and title are encoded for sharing posts. Originally htmlEscape was used; however, it only escapes few characters and it breaks the generated urls.

For example, if a post title was "What's in today?", the quote ' would be encoded as ' which broke the link.
Besides that, htmlEscape only tried to fix few characters.

So instead of using htmlEscape we should use urlquery which encodes all characters that are required in the string.
However, urlquery encodes + as %2B and (i.e., space) as +:
https://cs.opensource.google/go/go/+/refs/tags/go1.18.2:src/net/url/url.go;drc=7791e934c882fd103357448aee0fd577b20013ce;l=285
Because of this mailto links were still having trouble with + and spaces, so we re-encode the "+spaces" into %20, so they decode correctly for mailto.

[netlify]

✅ Deploy Preview for hugo-portfolio-theme ready!

Name	Link
🔨 Latest commit	67942fd
🔍 Latest deploy log	https://app.netlify.com/sites/hugo-portfolio-theme/deploys/62f8f4d78175d50008bcdc52
😎 Deploy Preview	https://deploy-preview-2726--hugo-portfolio-theme.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[netlify]

✅ Deploy Preview for markdown-slides ready!

Name	Link
🔨 Latest commit	67942fd
🔍 Latest deploy log	https://app.netlify.com/sites/markdown-slides/deploys/62f8f4d747e888000871260a
😎 Deploy Preview	https://deploy-preview-2726--markdown-slides.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[gcushen]

Thanks for spotting this issue with using Hugo's htmlEscape and proposing using urlquery instead.

Note: the urlquery function appears to be an undocumented Hugo feature as well as a Go function: gohugoio/hugoDocs#1627 (comment)

[cbdm]

Yep, I couldn't find anything on https://gohugo.io/functions/
Then when I was implementing this same functionality I saw the link for the go built-ins available (https://pkg.go.dev/text/template#hdr-Functions) and urlquery was there :)

EDIT: just saw you said it's also an undocumented Hugo feature! That I didn't know haha

[rodrigoalcarazdelaosa]

Does this fix this issue without doing anything extra?

[cbdm]

Does this fix this issue without doing anything extra?

Yes! As far as I tested that should be enough to fix that.