This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Chat list, chat API, functionalities to chat page and bug fixes #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many text themes used the same color, so I refactored them into a single text theme.
* Extracted the concatenateNames function to it's own file (it will be used by the chatList page); * Minor refactoring in theme to bundle together placeholder and invalid texts as faded text;
* Created chat list page (with mocks, and without testing the backend); * Registered page in routes and drawer menu; * Created Chat types and mocks for Chat API; * Additions to firebase types, animal API, adoption API and theme; * Added styling for infiniteScroll no data found container;
createChat, getOwnChats, pushMessages
Using types from types/firebase
Using types from types/firebase
…hat_list Removing animalUID from chat route params
Too many other fixes to list
* Created function that formats a chat date into text; * Used function in chat lists page;
…nto 093_chat_list
AndreLaranjeira
commented
May 6, 2021
AndreLaranjeira
commented
May 6, 2021
AndreLaranjeira
commented
May 6, 2021
AndreLaranjeira
commented
May 6, 2021
AndreLaranjeira
commented
May 6, 2021
AndreLaranjeira
commented
May 6, 2021
|
I can't officially approve my own PR, but, for all intents and purposes: approved! If someone could actually address those minor comments, all the better. |
Hugo-NF
reviewed
May 7, 2021
| @@ -219,11 +180,11 @@ export default (): JSX.Element => { | |||
| messages={messages} | |||
| loadEarlier | |||
| infiniteScroll | |||
| isLoadingEarlier={isLoadingEarlier} | |||
There was a problem hiding this comment.
Probably we don't need this state anymore.
Hugo-NF
approved these changes
May 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Closes #91 and #92.
How has this been tested?
Tested in bits by all 3 different members.
Screenshots (if appropriate):
Types of changes
Checklist: