Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipelines and associations APIs are deprecated #207

Open
fonji opened this issue Nov 6, 2019 · 2 comments
Open

Pipelines and associations APIs are deprecated #207

fonji opened this issue Nov 6, 2019 · 2 comments

Comments

@fonji
Copy link
Contributor

fonji commented Nov 6, 2019

Hubspot source

Pipelines and associations APIs currently used by this gem are deprecated.
Sunset is early 2020.

I'm currently working on #120 to update it to the changes made in this gem, so it's the right time to use the new endpoint.
But I don't think I should limit to Deals, and we should implement something to access the associations API.

I guess we need a new Association class, but the relations with other models might be tricky.
If you have an opinion about how to work this out, please let me know.
I'll try to make a PR in the meantime, but I'll limit it to associations.

As I don't use pipelines, can someone else look into it?

@fonji
Copy link
Contributor Author

fonji commented Nov 21, 2019

#210 takes care of associations.
I don't use the deal pipelines API, so I guess it would be better if someone else manages the upgrade.

@sallesma
Copy link

sallesma commented Dec 9, 2019

Hi @adimichele

There are several contributions waiting for review. This one seems to have an impact quite soon on projects using the gem.

Is there a chance for it to be reviewed in the upcoming days or weeks ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants