Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a consistent return value for each action #174

Open
SViccari opened this issue Dec 26, 2018 · 1 comment
Open

Define a consistent return value for each action #174

SViccari opened this issue Dec 26, 2018 · 1 comment

Comments

@SViccari
Copy link
Contributor

The return values for each action vary for each class and vary for instance methods and class methods. This inconsistent behavior can be confusing to users and those interested in contributing to the library.

For example, depending on which class you're using, calling .update! or #update! will vary between returning a hash or an instance of the class.

How can we make this consistent and give our users the best experience?

@SViccari
Copy link
Contributor Author

PR #171 proposes a way to make the response for all actions consistent and give users all the context that's provided by the HubSpot API response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant