Use type converter when evaulting 'in' #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 25, 2019 15:36
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
============================================
- Coverage 71.27% 71.26% -0.02%
- Complexity 1558 1559 +1
============================================
Files 239 239
Lines 4899 4907 +8
Branches 787 790 +3
============================================
+ Hits 3492 3497 +5
- Misses 1126 1127 +1
- Partials 281 283 +2
Continue to review full report at Codecov.
|
boulter
approved these changes
Mar 25, 2019
added 2 commits
March 25, 2019 15:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When evaluating
in(for example{{ 3 in [1, 2, 3] }}we should use the type converter to compare3to the list values.