Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use type converter when evaulting 'in' #314

Merged
merged 6 commits into from
Mar 25, 2019
Merged

Use type converter when evaulting 'in' #314

merged 6 commits into from
Mar 25, 2019

Conversation

mattcoley
Copy link
Collaborator

When evaluating in (for example {{ 3 in [1, 2, 3] }} we should use the type converter to compare 3 to the list values.

@mattcoley mattcoley requested a review from boulter March 25, 2019 19:31
@codecov-io
Copy link

codecov-io commented Mar 25, 2019

Codecov Report

Merging #314 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #314      +/-   ##
============================================
- Coverage     71.27%   71.26%   -0.02%     
- Complexity     1558     1559       +1     
============================================
  Files           239      239              
  Lines          4899     4907       +8     
  Branches        787      790       +3     
============================================
+ Hits           3492     3497       +5     
- Misses         1126     1127       +1     
- Partials        281      283       +2
Impacted Files Coverage Δ Complexity Δ
...t/jinjava/el/ext/CollectionMembershipOperator.java 65% <66.66%> (-1.67%) 5 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb701de...aad3611. Read the comment docs.

@mattcoley mattcoley merged commit 1d475ba into master Mar 25, 2019
@mattcoley mattcoley deleted the fix-in branch March 25, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants