Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade format filter to advanced filter. #279

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Conversation

mattcoley
Copy link
Collaborator

Making this an advanced filter allows us to do more powerful formats. For example, '%,d'|format(10000) to format the number to use commas: 10,000.

@codecov-io
Copy link

Codecov Report

Merging #279 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #279   +/-   ##
=========================================
  Coverage     72.35%   72.35%           
  Complexity     1483     1483           
=========================================
  Files           231      231           
  Lines          4597     4597           
  Branches        737      737           
=========================================
  Hits           3326     3326           
  Misses         1016     1016           
  Partials        255      255
Impacted Files Coverage Δ Complexity Δ
...a/com/hubspot/jinjava/lib/filter/FormatFilter.java 100% <100%> (ø) 3 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8377d8...55a0e3a. Read the comment docs.

@mattcoley mattcoley merged commit 357d592 into master Feb 4, 2019
@mattcoley mattcoley deleted the format-advanced branch February 4, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants