Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number errors. #222

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Limit the number errors. #222

merged 1 commit into from
Aug 16, 2018

Conversation

hs-lsong
Copy link
Collaborator

We could get a very larger number of error store in the memory. Limited number of errors should be enough for debugging purpose.

@mattcoley
Copy link
Collaborator

Could we add a new error like TemplateErrorMaxReached so if someone is scrolling down a list of errors they will see that one as the last error added.

@codecov-io
Copy link

Codecov Report

Merging #222 into master will decrease coverage by 0.02%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #222      +/-   ##
============================================
- Coverage     71.44%   71.42%   -0.03%     
- Complexity     1373     1374       +1     
============================================
  Files           218      218              
  Lines          4336     4343       +7     
  Branches        689      689              
============================================
+ Hits           3098     3102       +4     
- Misses          998     1000       +2     
- Partials        240      241       +1
Impacted Files Coverage Δ Complexity Δ
...n/java/com/hubspot/jinjava/lib/tag/IncludeTag.java 84% <100%> (ø) 4 <0> (ø) ⬇️
...main/java/com/hubspot/jinjava/lib/tag/FromTag.java 88.09% <100%> (ø) 9 <0> (ø) ⬇️
src/main/java/com/hubspot/jinjava/Jinjava.java 97.61% <100%> (ø) 16 <0> (ø) ⬇️
...in/java/com/hubspot/jinjava/lib/tag/ImportTag.java 71.42% <100%> (ø) 7 <0> (ø) ⬇️
.../hubspot/jinjava/interpret/JinjavaInterpreter.java 77.57% <55.55%> (-0.91%) 48 <3> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0ab6c4...2e6ffaa. Read the comment docs.

@hs-lsong
Copy link
Collaborator Author

hs-lsong commented Aug 16, 2018

I don't see why that is helpful. If you have enough errors, does it matter if the max is reached or not?

@mattcoley
Copy link
Collaborator

A code editor could show everything below that line as a yellow warning.

@hs-lsong
Copy link
Collaborator Author

It is easy to add if the code editor wants that.

@hs-lsong hs-lsong merged commit 6459e8f into master Aug 16, 2018
@hs-lsong hs-lsong deleted the errors branch August 16, 2018 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants