Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw object to group in groupby filter. #218

Merged
merged 2 commits into from
Aug 10, 2018
Merged

Add raw object to group in groupby filter. #218

merged 2 commits into from
Aug 10, 2018

Conversation

mattcoley
Copy link
Collaborator

If you use the groupby filter, the actual group object is a string, however in many cases you need the underlying group object. This allows you to get the object by calling group.grouperObject. I had to add a new property for backwards compatibility reasons unfortunately.

@codecov-io
Copy link

Codecov Report

Merging #218 into master will increase coverage by 0.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #218      +/-   ##
============================================
+ Coverage     71.46%   71.48%   +0.01%     
- Complexity     1364     1365       +1     
============================================
  Files           217      217              
  Lines          4297     4303       +6     
  Branches        683      684       +1     
============================================
+ Hits           3071     3076       +5     
- Misses          985      986       +1     
  Partials        241      241
Impacted Files Coverage Δ Complexity Δ
.../com/hubspot/jinjava/lib/filter/GroupByFilter.java 90% <88.88%> (-1.67%) 6 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 877760b...7011934. Read the comment docs.

@mattcoley mattcoley merged commit 97d1219 into master Aug 10, 2018
@mattcoley mattcoley deleted the group-by-raw branch August 10, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants