Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JinjaInterpreter instantiates with same class, no chance to use extended one #342

Closed
Roobun opened this issue Jun 17, 2019 · 2 comments
Closed

JinjaInterpreter instantiates with same class, no chance to use extended one #342

Roobun opened this issue Jun 17, 2019 · 2 comments

Comments

@Roobun
Copy link
Contributor

Roobun commented Jun 17, 2019

Hi, we extended JinjaInterpreter class, but there's some places where new Interpreters instantiates by JinjaInterpreter itself (e.g ImportTag class). Could you please provide an opportunity to make new objects with given extended class?
@Roobun Roobun changed the title JinjaInterpreter instantiates with new JinjaInterpreter instantiates with same class, no chance to use extended one Jun 17, 2019
@Roobun
Copy link
Contributor Author

Roobun commented Jun 26, 2019

Added a PR for that problem: #347

@Roobun
Copy link
Contributor Author

Roobun commented Jul 10, 2019

Mentioning @mattcoley @boulter as reviewers.

@Roobun Roobun closed this as completed Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Roobun