Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float type coercion has changed #184

Closed
anthmatic opened this issue Apr 5, 2018 · 2 comments
Closed

Float type coercion has changed #184

anthmatic opened this issue Apr 5, 2018 · 2 comments
Assignees

Comments

@anthmatic
Copy link
Contributor

Previously the float filter would return 0.0 when trying to coerce a non-numeric string. It looks like after #178 (change to numberFormat.parse()) strings that start with numbers can be converted to floating point numbers.

Before:
"30%"|float == 0

After #178 :
"30%"|float == 30

@pfarrel
Copy link
Contributor

pfarrel commented Apr 13, 2018

Hey @anthmatic, you're right, that was an unintentional change. I'll look at fixing it.

@boulter
Copy link
Contributor

boulter commented May 2, 2018

I believe this was fixed by #191

@boulter boulter closed this as completed May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants