Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure fetching a folder with spaces in the name works as expected on Windows 10 #85

Closed
gcorne opened this issue Feb 13, 2020 · 7 comments
Assignees

Comments

@gcorne
Copy link
Contributor

gcorne commented Feb 13, 2020

No description provided.

@corymartin corymartin self-assigned this Feb 13, 2020
@corymartin
Copy link
Contributor

Screen Shot 2020-02-13 at 15 58 10

Works with root dir, nested dirs, and files with spaces.

@corymartin
Copy link
Contributor

The issue is npx. It seems to affect parameter parsing.

Correctly fetches remote dir "/Custom modules"

npm install -g @hubspot/cms-cli
hs fetch "Custom modules" test

Incorrectly fetches remote dir "/Custom"

npx hs fetch "Custom modules" test

@corymartin corymartin reopened this Feb 14, 2020
@corymartin
Copy link
Contributor

Maybe related npm/npx#6

@corymartin
Copy link
Contributor

npx on Windows certainly has trouble with string params. I made a simple module consisting of console.log(process.argv) and this was the output using npx

Screen Shot 2020-02-19 at 18 14 17

@corymartin
Copy link
Contributor

npm/npx#14

@mrinalpathak16
Copy link

@anthmatic anthmatic mentioned this issue Jun 26, 2020
@miketalley
Copy link
Contributor

Cannot repro this in windows. Seems to be working
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants