-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 519: Support multiple YamlConfigurationSercvices #521
Issue 519: Support multiple YamlConfigurationSercvices #521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment.
I would also say that the name handling is not always clear in general in the code, but I'm not sure what to do about that..
@@ -110,18 +108,17 @@ internal class OriginsConfigConverter( | |||
|
|||
val serviceConfig = MAPPER.readTree(str) | |||
|
|||
val providerObject = Builtins.build(StyxObjectDefinition(appId, HEALTH_CHECK_MONITOR, serviceConfig), | |||
val providerObject = Builtins.build("providerName", StyxObjectDefinition(appId, HEALTH_CHECK_MONITOR, serviceConfig), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name parameter is ignored by the HC factory - perhaps make it clearer that the value here is not significant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this. I have refactored so that a correct name is always passed in. Even if .build()
ignores it.
I tend to agree this can be improved. As always, I'm open for constructive feedback :-) |
Summary
Fixes: #519
Provides equivalent functionality to
BackendServiceProxy
when usingYamlConfigurationFileService
to configure styx from origins file.Add a new
ingressObject
attribute toYamlConfigurationFileService
. It names the routing object serving as an entry point for backend services sourced from the yaml configuration service. In practice it is the ingress object is a PathPrefixRouter.When
ingressObject
is absent, the name is derived fromYamlConfigurationFileService
provider name as follows<name>-router
.Rename source tag for generated routing objects. The source tag now specifies the provider object name instead of its type.
Rename generated health check services. The names now have
-monitor
postfix. For example if the provider name isfoo
then the health check provider name will befoo-monitor
.Configuration Example