Service cleanup #390
Merged
Service cleanup #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvlato
reviewed
Mar 27, 2019
components/proxy/src/main/java/com/hotels/styx/admin/AdminServerBuilder.java
Outdated
Show resolved
Hide resolved
mikkokar
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was branched from #389 so please review/merge that one first, or you will see the changes from both branches at once.
This PR fixes two types of problems with our
NettyServerandStyxServerclasses, with respect to behaving as services:NettyServerinstances (proxy and admin) are doing some of the start-up before the service is actuallySTARTING(i.e. construction time or before). We move it to the correct location.